Update Drop.App version#5239
Conversation
a11d4a9 to
2b2a717
Compare
|
Will this flow to master? |
|
I presume it should flow to master yes? Also, could you fill out the template please @rainersigwald ? |
|
This change should go to master. But it looks like there's no automatic RI in this repo? https://github.com/dotnet/arcade/tree/release/3.x says Do y'all do dual checkins? |
Yep, we do. The prefered flow in Arcade is to make the change in Master first, then port your change to release/3.x and fill out the template: Template for the PR to release branch: https://github.com/dotnet/arcade/blob/master/Documentation/Policy/AskModeTellModeTemplate.md |
|
Ah, I was missing a refresh to see that you were already using the template. |
Old `drop.exe` has an issue with a recent Windows security update, which causes failures like ``` ContentStore.Exceptions.CacheException: Could not download into the cache: ErrorMessage=[FileNotFoundException: System.IO.FileNotFoundException: Could not find file 'C:\_cache\contents\Shared\VSO0\ED8\ED878A5B6B0E382A858F9F34A562E42BFE8A70032E7E900F13CF4EE3621D8E4900.blob'. ``` When downloading drop data. The Azure Artifacts team recommends updating to 18.164.29918 or newer.
2b2a717 to
b5d183a
Compare
|
Ok. I rebased this back to the merge-base, so it can go in whichever branch y'all want to land first. I can then open another PR for the other one. |
|
Ping. Should we merge this? |
|
@JohnTortugo who are you pinging, exactly? I'm waiting for someone with permissions to merge :) |
…5258)" This reverts commit f516095. This workaround is no longer needed after dotnet/arcade#5239.
…#5401) This reverts commit f516095. This workaround is no longer needed after dotnet/arcade#5239.
Description
Old
drop.exehas an issue with a recent Windows security update, whichcauses failures like
When downloading drop data. The Azure Artifacts team recommends updating
to 18.164.29918 or newer.
Customer Impact
Builds that acquire OptProf data fail with mysterious error (on some OSes).
Regression
Yes, but not in Arcade: Windows and/or Drop.exe is the problem here.
Risk
Low. Slight chance that the latest
Drop.Apppackage has some functional regression.Workarounds
Override the package version at a repo level.