Skip to content

Remove launchsettings#3240

Merged
ViktorHofer merged 1 commit intodotnet:masterfrom
ViktorHofer:LaunchSettingsRemoval
Jul 8, 2019
Merged

Remove launchsettings#3240
ViktorHofer merged 1 commit intodotnet:masterfrom
ViktorHofer:LaunchSettingsRemoval

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

The benefit of having launchsettings files isn't existent anymore. Instead we can rely on the environment variables feature in the VS Debugging section (which will simply generate a launchsettings.json file) and have the same behavior on CLI and inside VS.

I'm not porting the -parallel none switch over from the template json file as the equivalent XUnitMaxThreads setting is available which can be set as env var in the Debug section. Reason for that is that with that switch F5 is far slower than running from the console and for debugging purposes VS Test Explorer is possible now.

@ViktorHofer ViktorHofer requested a review from ericstj July 7, 2019 16:58
@ViktorHofer ViktorHofer self-assigned this Jul 7, 2019
@ViktorHofer
Copy link
Copy Markdown
Member Author

ViktorHofer commented Jul 7, 2019

As soon as VS Test Explorer and dotnet test is enabled and property names are refined, I plan to write a doc with possible switches for the env var section & CLI global properties.

@ViktorHofer
Copy link
Copy Markdown
Member Author

Merging meanwhile to unblock some of my work.

@ViktorHofer ViktorHofer merged commit 4953cdf into dotnet:master Jul 8, 2019
@ViktorHofer ViktorHofer deleted the LaunchSettingsRemoval branch July 8, 2019 07:02
Copy link
Copy Markdown
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ViktorHofer added a commit to ViktorHofer/arcade that referenced this pull request Jul 8, 2019
ViktorHofer added a commit that referenced this pull request Jul 8, 2019
* Revert "Remove launchsettings (#3240)"

This reverts commit 4953cdf.

* Simply launchSettings.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants