Move to Microsoft.Net.Compilers.Toolset#2131
Conversation
This is a unified NuPkg for the desktop and coreclr Roslyn compilers. Removes the need to special case based on the MSBuild runtime at restore time. Instead there is one restore and at build time the correct compiler task is loaded based on the runtime.
|
super cool |
|
Do we want the version to flow automatically? That is whatever version Arcade repo is using will be set as the default. |
|
FYI: msbuild, Roslyn and CoreFX repos use MicrosoftNetCompilersVersion: |
|
@tmat yeah we'll have to update all those repositories when they take this change. I know @tannergooding is looking at CoreFX, I'm working on roslyn and I can work with @rainersigwald on msbuild |
The version of Microsoft.Net.Compilers.Toolset? Yes. That's what we did for toolsets in the previous iteration and should be doing now. Yeah the toolset is newer here but it's the .NET Core Preview3 toolset. We should all be using it. |
|
So in order to flow the package into defaults add <MicrosoftNetCompilersToolsetVersion>$(MicrosoftNetCompilersToolsetVersion)</MicrosoftNetCompilersToolsetVersion>here, set the property in Arcade's eng/Versions.props and remove https://github.com/dotnet/arcade/pull/2131/files#diff-f1b1f6d246bc1f9a81d8ea1c4498e3a5R54. That way Arcade SDK build captures the version of the package that's used to build it and flows it to all repos that will be using that Arcade SDK. Maestro will then flow the version if Arcade repo has a subscription to Roslyn. |
|
Once this goes in and is pushed through, I'll update CoreFX to get the version from here. Looks like this will just require |
|
@tannergooding Yes. |
| <MicrosoftDotNetIBCMergeVersion Condition="'$(MicrosoftDotNetIBCMergeVersion)' == ''">4.8.0-beta.19111.1</MicrosoftDotNetIBCMergeVersion> | ||
| <MicrosoftNetCompilersVersion Condition="'$(MicrosoftNetCompilersVersion)' == ''">2.8.0</MicrosoftNetCompilersVersion> | ||
| <MicrosoftNETCoreCompilersVersion Condition="'$(MicrosoftNETCoreCompilersVersion)' == ''">$(MicrosoftNetCompilersVersion)</MicrosoftNETCoreCompilersVersion> | ||
| <MicrosoftNetCompilersToolsetVersion Condition="'$(MicrosoftNetCompilersToolsetVersion)' == ''">3.1.0-beta1-19127-06</MicrosoftNetCompilersToolsetVersion> |
There was a problem hiding this comment.
Maybe warn users who have UsingToolMicrosoftNetCompilers=true and who also define MicrosoftNetCompilersVersion so they know to switch/update?
There was a problem hiding this comment.
We know the teams who do this and they've all been notified.
|
@tmat updated |
| <Project> | ||
| <PropertyGroup> | ||
| <ArcadeSdkVersion>$(PackageVersion)</ArcadeSdkVersion> | ||
| <MicrosoftNetCompilersToolsetVersion>$(MicrosoftNetCompilersToolsetVersion)</MicrosoftNetCompilersToolsetVersion> |
There was a problem hiding this comment.
Is the file rewritten as part of build?
There was a problem hiding this comment.
(I saw Tomas' comment here: #2131 (comment), not sure quite how it flows though).
MSBuild implications of dotnet/arcade#2131.
* Update dependencies from https://github.com/dotnet/arcade build 20190213.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19113.1 * Update dependencies from https://github.com/dotnet/arcade build 20190214.4 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19114.4 * Update dependencies from https://github.com/dotnet/arcade build 20190215.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19115.1 * Update dependencies from https://github.com/dotnet/arcade build 20190219.2 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19119.2 * Update dependencies from https://github.com/dotnet/arcade build 20190221.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19121.1 * Update dependencies from https://github.com/dotnet/arcade build 20190221.5 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19121.5 * Update dependencies from https://github.com/dotnet/arcade build 20190222.3 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19122.3 * Update dependencies from https://github.com/dotnet/arcade build 20190223.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19123.1 * Update dependencies from https://github.com/dotnet/arcade build 20190224.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19124.1 * Update dependencies from https://github.com/dotnet/arcade build 20190225.2 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19125.2 * Update dependencies from https://github.com/dotnet/arcade build 20190226.6 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19126.6 * Update dependencies from https://github.com/dotnet/arcade build 20190227.8 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19127.8 * Use Microsoft.Net.Compilers.Toolset in bootstrap MSBuild implications of dotnet/arcade#2131. * Disable NormalizePathBadGlobalroot test Bug for future investigation: #4205. * Update dependencies from https://github.com/dotnet/arcade build 20190228.3 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19128.3 * Update dependencies from https://github.com/dotnet/arcade build 20190301.5 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19151.5 * Update dependencies from https://github.com/dotnet/arcade build 20190304.14 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19154.14 * Update dependencies from https://github.com/dotnet/arcade build 20190305.29 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19155.29 * Update dependencies from https://github.com/dotnet/arcade build 20190306.20 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19156.20 * Update dependencies from https://github.com/dotnet/arcade build 20190307.23 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19157.23
This is a unified NuPkg for the desktop and coreclr Roslyn compilers.
Removes the need to special case based on the MSBuild runtime at restore
time. Instead there is one restore and at build time the correct
compiler task is loaded based on the runtime.