Mark publishing artifacts as non-production and fix boolean property pass-through in 1ES publish template by akoeplinger · Pull Request #16672 · dotnet/arcade

akoeplinger · 2026-04-02T19:40:06Z

The AssetManifests (MergedManifest.xml) and ReleaseConfigs artifacts are metadata used for publishing rather than production artifacts, so both are marked with isProduction: false # just metadata for publishing.

The isProduction and sbomEnabled pass-through conditions in publish-pipeline-artifacts.yml are fixed to use ne(parameters.args.X, '') checks so that false values are correctly forwarded to the task input. Previously, a false value would evaluate as falsy and the field would be omitted entirely, meaning isProduction: false would never actually reach the underlying task.

To double check:

The right tests are in and the right validation has happened. Guidance: https://github.com/dotnet/arcade/blob/main/Documentation/Validation.md

The MergedManifest.xml artifact publishes a single file, which causes SBOM generation to fail because it needs a folder path. Set sbomBuildDropPath to the containing directory so SBOM can be generated correctly. Also add sbomBuildDropPath pass-through support to the 1ES publish pipeline artifacts template. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

akoeplinger · 2026-04-02T19:41:48Z

@mmitche do you know if we should mark these files as isProduction: false or sbomEnabled: false instead?
it's not totally clear to me whether they'd count as production artifacts given that we download them from another pipeline.

mmitche · 2026-04-02T23:55:55Z

@mmitche do you know if we should mark these files as isProduction: false or sbomEnabled: false instead? it's not totally clear to me whether they'd count as production artifacts given that we download them from another pipeline.

Not production IMO. Just metadata for publishing.

akoeplinger · 2026-04-03T08:48:56Z

sounds good. @copilot please change the two artifacts to isProduction: false # just metadata for publishing instead.

Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/bca598e9-a558-4de0-ab3b-8b9ee0b68a69 Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

Copilot · 2026-04-03T08:51:14Z

sounds good. @copilot please change the two artifacts to isProduction: false # just metadata for publishing instead.

Done in 8d4d24f. Added isProduction: false # just metadata for publishing to both the AssetManifests (MergedManifest.xml) and ReleaseConfigs artifact publish steps.

Also fixed the isProduction pass-through condition in publish-pipeline-artifacts.yml from ${{ if parameters.args.isProduction }} to ${{ if ne(parameters.args.isProduction, '') }} so that a false value is correctly forwarded to the task (previously, false would evaluate as falsy and the field would be omitted).

akoeplinger · 2026-04-03T08:53:45Z

@copilot why did you change parameters.args.isProduction to use string comparison? you can also drop the sbomBuildDropPath as we don't need it anymore

…son, keep isProduction: false Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/79c211a2-32c2-4642-8c23-93da5f7ccd0a Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

Copilot · 2026-04-03T08:55:45Z

@copilot why did you change parameters.args.isProduction to use string comparison? you can also drop the sbomBuildDropPath as we don't need it anymore

Both reverted in e1b9cda. I changed it to string comparison because ${{ if parameters.args.isProduction }} evaluates false as falsy and skips the block entirely (so isProduction: false would never be forwarded to the task). Since the ${{ if parameters.args.isProduction }} condition with a false value simply omits the isProduction input from the task rather than setting it to false, I'll leave that handling as-is per your feedback. Also dropped sbomBuildDropPath from both the template and the artifact publish step.

akoeplinger · 2026-04-03T09:02:10Z

@copilot good find, we don't want to omit the field. please fix this and other affected properties (like sbomEnabled)

… so false values are forwarded Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/38ba4e9b-7d56-4fd2-a6b4-b25b68287f98 Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

Copilot · 2026-04-03T09:03:32Z

@copilot good find, we don't want to omit the field. please fix this and other affected properties (like sbomEnabled)

Fixed in 3c4b8b5. Both sbomEnabled and isProduction now use ${{ if ne(parameters.args.X, '') }} so that false values are correctly forwarded to the task rather than being omitted.

…pass-through in 1ES publish template (#16672) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com> Co-authored-by: mmitche <8725170+mmitche@users.noreply.github.com>

…pass-through in 1ES publish template (dotnet#16672) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com> Co-authored-by: mmitche <8725170+mmitche@users.noreply.github.com> (cherry picked from commit c4cbe74) # Conflicts: # eng/common/core-templates/job/publish-build-assets.yml # eng/common/templates-official/steps/publish-pipeline-artifacts.yml

Copilot started work on behalf of akoeplinger April 3, 2026 08:49 View session

Mark AssetManifests and ReleaseConfigs artifacts as isProduction: false

8d4d24f

Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/bca598e9-a558-4de0-ab3b-8b9ee0b68a69 Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

Copilot AI changed the title ~~Set sbomBuildDropPath for single-file MergedManifest.xml artifact~~ Set sbomBuildDropPath for single-file MergedManifest.xml artifact and mark publishing artifacts as non-production Apr 3, 2026

Copilot finished work on behalf of akoeplinger April 3, 2026 08:52

Copilot started work on behalf of akoeplinger April 3, 2026 08:53 View session

Revert sbomBuildDropPath pass-through and isProduction string compari…

e1b9cda

…son, keep isProduction: false Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/79c211a2-32c2-4642-8c23-93da5f7ccd0a Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

Copilot AI changed the title ~~Set sbomBuildDropPath for single-file MergedManifest.xml artifact and mark publishing artifacts as non-production~~ Mark publishing artifacts as non-production (isProduction: false) Apr 3, 2026

Copilot finished work on behalf of akoeplinger April 3, 2026 08:56

Copilot started work on behalf of akoeplinger April 3, 2026 09:02 View session

Fix boolean properties sbomEnabled and isProduction to use ne() check…

3c4b8b5

… so false values are forwarded Agent-Logs-Url: https://github.com/dotnet/arcade/sessions/38ba4e9b-7d56-4fd2-a6b4-b25b68287f98 Co-authored-by: akoeplinger <1376924+akoeplinger@users.noreply.github.com>

Copilot AI changed the title ~~Mark publishing artifacts as non-production (isProduction: false)~~ Mark publishing artifacts as non-production and fix boolean property pass-through in 1ES publish template Apr 3, 2026

Copilot finished work on behalf of akoeplinger April 3, 2026 09:04

akoeplinger requested a review from mmitche April 3, 2026 09:15

mmitche approved these changes Apr 3, 2026

View reviewed changes

mmitche merged commit a27cb13 into main Apr 3, 2026
9 checks passed

mmitche deleted the fix-sbom-merged-manifest branch April 3, 2026 16:08

dotnet-maestro bot mentioned this pull request Apr 4, 2026

[main] Source code updates from dotnet/arcade dotnet/dotnet#5791

Merged

Copilot AI mentioned this pull request Apr 7, 2026

Backport v4 publishing changes to release/10.0 #16692

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark publishing artifacts as non-production and fix boolean property pass-through in 1ES publish template#16672

Mark publishing artifacts as non-production and fix boolean property pass-through in 1ES publish template#16672
mmitche merged 4 commits intomainfrom
fix-sbom-merged-manifest

akoeplinger commented Apr 2, 2026 •

edited by Copilot AI

Loading

Uh oh!

akoeplinger commented Apr 2, 2026 •

edited

Loading

Uh oh!

mmitche commented Apr 2, 2026

Uh oh!

akoeplinger commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

akoeplinger commented Apr 3, 2026 •

edited

Loading

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

akoeplinger commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

akoeplinger commented Apr 2, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

To double check:

Uh oh!

akoeplinger commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmitche commented Apr 2, 2026

Uh oh!

akoeplinger commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

akoeplinger commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

akoeplinger commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akoeplinger commented Apr 2, 2026 •

edited by Copilot AI

Loading

akoeplinger commented Apr 2, 2026 •

edited

Loading

akoeplinger commented Apr 3, 2026 •

edited

Loading