Skip to content

Update xcopy-msbuild to 18.0.0#16316

Merged
mmitche merged 1 commit intomainfrom
meghnave/update_msbuildxcopy_version
Nov 24, 2025
Merged

Update xcopy-msbuild to 18.0.0#16316
mmitche merged 1 commit intomainfrom
meghnave/update_msbuildxcopy_version

Conversation

@meghnave
Copy link
Contributor

To double check:

@meghnave meghnave marked this pull request as ready for review November 15, 2025 02:07
@wfurt
Copy link
Member

wfurt commented Nov 18, 2025

Why are we changing it? It would be nice to have some link or background.

@mmitche
Copy link
Member

mmitche commented Nov 24, 2025

10.0 is only supported on 18.0.0. That may have been the motivating factor.

@mmitche mmitche merged commit d013ca7 into main Nov 24, 2025
10 checks passed
@mmitche mmitche deleted the meghnave/update_msbuildxcopy_version branch November 24, 2025 20:15
@mmitche
Copy link
Member

mmitche commented Nov 24, 2025

@meghnave Does this need to go back to release/10.0?

@akoeplinger
Copy link
Member

I see failures in release/10.0 that are related to this, so yes

@akoeplinger
Copy link
Member

/backport to release/10.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Started backporting to release/10.0 (link to workflow run)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

@akoeplinger backporting to release/10.0 failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update xcopy-msbuild to 18.0.0
Using index info to reconstruct a base tree...
M	eng/common/sdk-task.ps1
M	eng/common/tools.ps1
Falling back to patching base and 3-way merge...
Auto-merging eng/common/sdk-task.ps1
CONFLICT (content): Merge conflict in eng/common/sdk-task.ps1
Auto-merging eng/common/tools.ps1
CONFLICT (content): Merge conflict in eng/common/tools.ps1
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Update xcopy-msbuild to 18.0.0
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

@akoeplinger
Copy link
Member

Manual backport: #16367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants