[release/10.0] Allow use of internal sdk#16267
Merged
mmitche merged 2 commits intorelease/10.0from Nov 6, 2025
Merged
Conversation
mmitche
reviewed
Nov 4, 2025
| # Populate internal runtime variables. | ||
| - template: /eng/common/templates/steps/enable-internal-sources.yml | ||
| parameters: | ||
| legacyCredential: $(dn-bot-dnceng-artifact-feeds-rw) |
Member
There was a problem hiding this comment.
This legacy credential shouldn't be required if the org is dnceng (project is internal)
Member
Author
There was a problem hiding this comment.
But can t this run on devdiv too ?
Member
There was a problem hiding this comment.
Right...I would conditionalzie the passing of this property on the project name. If devdiv, pass, otherwise don't.
Member
Member
Author
|
Hum the code changes are all on this PR, the only doubt is the white space fixes. |
mmitche
reviewed
Nov 5, 2025
|
|
||
| - task: NuGetAuthenticate@1 | ||
|
|
||
| # Populate internal runtime variables. |
premun
reviewed
Nov 6, 2025
| scriptPath: $(System.DefaultWorkingDirectory)/eng/common/sdk-task.ps1 | ||
| arguments: -task PublishBuildAssets -restore -msbuildEngine dotnet | ||
| -runtimeSourceFeed https://ci.dot.net/internal | ||
| -runtimeSourceFeedKey $(dotnetbuilds-internal-container-read-token-base64) |
Member
There was a problem hiding this comment.
You should go through the PR and add ' so that you don't hit the same issue
Suggested change
| -runtimeSourceFeedKey $(dotnetbuilds-internal-container-read-token-base64) | |
| -runtimeSourceFeedKey '$(dotnetbuilds-internal-container-read-token-base64)' |
Address feedback Fix identation Fix more token usage Fix build
a0f0841 to
b17e669
Compare
mmitche
approved these changes
Nov 6, 2025
akoeplinger
added a commit
that referenced
this pull request
Nov 19, 2025
akoeplinger
added a commit
that referenced
this pull request
Nov 19, 2025
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of changes made on #16251 since when I update the dependencies is trying to override the changes on our repos
This pull request updates the build and post-build pipelines to improve support for internal runtime feeds by adding new parameters and steps for securely accessing internal resources. The changes ensure that internal runtime variables are populated and passed through the relevant scripts and templates, enhancing the automation and security of the build process.
Pipeline and Template Enhancements:
enable-internal-sources.ymlandenable-internal-runtimes.ymltemplates in both thepublish-build-assets.ymlandpost-build.ymlfiles, ensuring internal feeds are accessible during builds. [1] [2]-runtimeSourceFeedand-runtimeSourceFeedKey, passing internal feed URLs and credentials to support secure access to internal runtime packages. [1] [2] [3] [4]Script Parameter Updates:
runtimeSourceFeedandruntimeSourceFeedKeytopublish-using-darc.ps1,redact-logs.ps1, andsdk-task.ps1to accept internal feed information, making the scripts more flexible and secure for internal builds. [1] [2] [3]