Fix NonShipping="true" metadata missing from asset manifest#15570
Merged
ViktorHofer merged 3 commits intomainfrom Feb 24, 2025
Merged
Fix NonShipping="true" metadata missing from asset manifest#15570ViktorHofer merged 3 commits intomainfrom
ViktorHofer merged 3 commits intomainfrom
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Feb 24, 2025
mmitche
reviewed
Feb 24, 2025
| <ItemGroup> | ||
| <ItemsToPushToBlobFeed> | ||
| <ManifestArtifactData Condition="'%(ItemsToPushToBlobFeed.IsShipping)' == 'false'">%(ItemsToPushToBlobFeed.ManifestArtifactData);NonShipping=true</ManifestArtifactData> | ||
| <ManifestArtifactData Condition="'%(ItemsToPushToBlobFeed.IsShipping)' != 'true'">%(ItemsToPushToBlobFeed.ManifestArtifactData);NonShipping=true</ManifestArtifactData> |
Member
There was a problem hiding this comment.
I don't think this is correct, as the default is that all artifacts are shipping.
Member
Author
There was a problem hiding this comment.
The IsShipping metadata is treated as a boolean here. Either it is true or not true. Conditioning on true and false makes it an enum which would make it easier to introduce unwanted behavior.
Why would this be incorrect?
Member
There was a problem hiding this comment.
if this was about the case where IsShipping is empty, that already defaults to true on L310:
<IsShipping Condition="'%(ItemsToPushToBlobFeed.IsShipping)' == ''">true</IsShipping>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change the
NonShippingmetadata is missing:I think this means that repos that update to the newest Arcade will publish their non-shipping assets to the non "-transport" feeds. This sounds pretty broken and should be mitigated asap.
To double check: