Merged
Conversation
mthalman
previously approved these changes
Feb 10, 2025
mmitche
reviewed
Feb 10, 2025
| <FeedOverride Include="https://dotnetbuilds.blob.core.windows.net/public" Replacement="$(InstallersFeedOverride)" Condition="'$(InstallersFeedOverride)' != ''"/> | ||
| <FeedOverride Include="https://dotnetbuilds.blob.core.windows.net/internal-checksums" Replacement="$(ChecksumsFeedOverride)" Condition="'$(ChecksumsFeedOverride)' != ''"/> | ||
| <FeedOverride Include="https://dotnetbuilds.blob.core.windows.net/internal" Replacement="$(InstallersFeedOverride)" Condition="'$(InstallersFeedOverride)' != ''"/> | ||
| <FeedSasUri Include="https://ci.dot.net/public" Base64Uri="$(DotNetBuildsPublicUriBase64)"/> |
Member
There was a problem hiding this comment.
The changes in PublishArtifactsInManifest.proj and PublishingConstants should be reverted. Those are the target storage accounts for publishing files. My guess is that the Azure blob storage clients won't like these URIs.
Similarly, the PublishArtifactInManifest.proj is a mapping between default target storage account locations and an override location that is used by our staging pipeline.
Member
Author
There was a problem hiding this comment.
Thanks for that. I was certain the changes were overstepping but didn't have the context.
PTAL if the changes look good.
mmitche
approved these changes
Feb 10, 2025
1 task
akoeplinger
pushed a commit
that referenced
this pull request
Nov 20, 2025
akoeplinger
pushed a commit
that referenced
this pull request
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wasn't entirely clear to me which of these should be updated. I skipped some instances that looked like they should be kept as blob storage. Perhaps there are others.