Add Lci files to LocProject.json#12620
Merged
alexperovich merged 2 commits intodotnet:mainfrom Feb 17, 2023
Merged
Conversation
eng/common/generate-locproject.ps1
Outdated
| if ($continue) { | ||
| return @{ | ||
| SourceFile = $sourceFile | ||
| LciFile = if (Test-Path $lciFile -PathType Leaf) {$lciFile} else {$null} |
Contributor
There was a problem hiding this comment.
I'm worried about this line resulting in LciFile: null in the final json (not sure what effect that will have). I think you can conditionalize the inclusion of items like I do here. Can you see if that will work for this? If not... guess we'll try this and see!
Member
Author
There was a problem hiding this comment.
it does, I can condition it
jonfortescue
approved these changes
Feb 17, 2023
Contributor
jonfortescue
left a comment
There was a problem hiding this comment.
Thanks so much for this!
This was referenced Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12559