Add platform moniker to workload pack MSI#11578
Merged
mmitche merged 1 commit intodotnet:release/6.0from Nov 11, 2022
Merged
Conversation
mmitche
approved these changes
Nov 10, 2022
Member
|
Does this need any change in the SDK Resolver for potential new workload names if the platform moniker is duplicated at the end now? |
Member
Author
It shouldn't. This only impacts the name of the MSI file itself. We have a standard pattern for the workload pack package that wraps the MSI that's derived from the original workload pack. That is what the CLI uses to locate the installer for the pack. |
pjcollins
approved these changes
Nov 10, 2022
nagilson
approved these changes
Nov 10, 2022
Member
Author
|
@mmitche Can you please help to merge? We verified the fix in a VS build |
joeloff
added a commit
to joeloff/arcade
that referenced
this pull request
Nov 11, 2022
mmitche
pushed a commit
that referenced
this pull request
Nov 11, 2022
joeloff
added a commit
to joeloff/arcade
that referenced
this pull request
Nov 11, 2022
joeloff
added a commit
that referenced
this pull request
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should always add the platform moniker to the generated workload pack MSI. We previously avoided this if the package for the workload pack contained the platform to avoid repeating platform information multiple times.
However, when using aliasing, e.g. taking an x64 pack and repurposing it for arm64, etc. we now end up with duplicate file names that results in conflicts when generating the visual studio manifests.
For example, a manifest like
would generate a single MSI named
Microsoft.AOT.win-x64.Cross.android-arm64.6.0.11-mauiarm.msi. With this change, we'll generate two MSIs instead.Microsoft.AOT.win-x64.Cross.android-arm64.6.0.11-mauiarm-arm64.msi
Microsoft.AOT.win-x64.Cross.android-arm64.6.0.11-mauiarm-x64.msi