Fix defect with Enum, abstract events generation. Implement AccessibilityFilter, AttributesFilter, ImplicitSymbolsFilter, IntersectionFilter.#11223
Merged
andriipatsula merged 6 commits intodotnet:mainfrom Oct 12, 2022
Conversation
premun
reviewed
Oct 12, 2022
src/Microsoft.DotNet.GenAPI/Shared/Filters/IntersectionFilter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.GenAPI/Shared/Filters/IntersectionFilter.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.GenAPI/Shared/Filters/FilterOutDelegateMembers.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.GenAPI/Shared/Filters/FilterOutImplicitSymbols.cs
Outdated
Show resolved
Hide resolved
premun
reviewed
Oct 12, 2022
Member
premun
left a comment
There was a problem hiding this comment.
My morning review was a bit quick so I did another one.
src/Microsoft.DotNet.GenAPI/Shared/Filters/IntersectionFilter.cs
Outdated
Show resolved
Hide resolved
premun
reviewed
Oct 12, 2022
Member
premun
left a comment
There was a problem hiding this comment.
There are some unresolved comments from the previous review + I have 2 new
src/Microsoft.DotNet.GenAPI/Shared/Filters/AccessibilityFilter.cs
Outdated
Show resolved
Hide resolved
premun
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
Implemented: