Skip to content

fix invalid job url in logs#11041

Merged
oleksandr-didyk merged 1 commit intodotnet:mainfrom
oleksandr-didyk:bug-invalid-log-url
Sep 28, 2022
Merged

fix invalid job url in logs#11041
oleksandr-didyk merged 1 commit intodotnet:mainfrom
oleksandr-didyk:bug-invalid-log-url

Conversation

@oleksandr-didyk
Copy link
Contributor

@oleksandr-didyk oleksandr-didyk commented Sep 28, 2022

Fix double slash in Helix URL in logs.

Example of invalid URL can be found here

@oleksandr-didyk oleksandr-didyk merged commit 839e1e3 into dotnet:main Sep 28, 2022
@oleksandr-didyk oleksandr-didyk deleted the bug-invalid-log-url branch September 28, 2022 15:46
@MattGal
Copy link
Member

MattGal commented Sep 30, 2022

@oleksandr-didyk this change does not likely work the way you expected, as seen in this build:

  Sent Helix Job; see work items at [System.String]::Copy('https://helix.dot.net/').TrimEnd('/')/api/jobs/ec0681d6-dd31-40c9-9715-5d98c27cd44b/workitems?api-version=2019-06-17&access_token={Get this from helix.dot.net}
  Sending Job to (Debian.10.Amd64)Ubuntu.2004.Amd64@mcr.microsoft.com/dotnet-buildtools/prereqs:debian-10-helix-amd64...
  Sent Helix Job; see work items at [System.String]::Copy('https://helix.dot.net/').TrimEnd('/')/api/jobs/d260bcd3-74db-4d67-80ba-601322070b21/workitems?api-version=2019-06-17&access_token={Get this from helix.dot.net}
  Waiting for completion of job ec0681d6-dd31-40c9-9715-5d98c27cd44b on Windows.10.Amd64

premun added a commit that referenced this pull request Oct 3, 2022
@premun
Revert "fix invalid job url in logs (#11041)"
8a58beb 
This reverts commit 839e1e3.
@premun premun mentioned this pull request Oct 3, 2022
Merged
@riarenas riarenas mentioned this pull request Oct 4, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@premun premun premun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-didyk @MattGal @premun