Remove legacy properties around blob feed publishing#10372
Merged
mmitche merged 2 commits intodotnet:mainfrom Sep 14, 2022
Merged
Remove legacy properties around blob feed publishing#10372mmitche merged 2 commits intodotnet:mainfrom
mmitche merged 2 commits intodotnet:mainfrom
Conversation
These properties don't have a use anywhere (DotNetPublishBlobFeedUrl and DotNetPublishBlobFeedKey) and are non-functional.
riarenas
approved these changes
Aug 10, 2022
| displayName: Publish logs | ||
| continueOnError: true | ||
| condition: always() | ||
| - ${{ if or(eq(parameters.artifacts.publish.manifests, 'true'), ne(parameters.artifacts.publish.manifests, '')) }}: |
Contributor
There was a problem hiding this comment.
It looks like this is the only place where we check for parameters.artifacts.publish.manifests. Should we also clean up
https://github.com/dotnet/arcade/blob/main/azure-pipelines.yml#L41 ?
Member
Author
There was a problem hiding this comment.
I think there are some other places. It seems to gate calling of the publish-build-assets template too.
There are like 3 versions of publishing with deprecated parameters in them....ugh
Member
Author
There was a problem hiding this comment.
- ${{ if and(eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
- ${{ if or(eq(parameters.enablePublishBuildAssets, true), eq(parameters.artifacts.publish.manifests, 'true'), ne(parameters.artifacts.publish.manifests, '')) }}:
- template: ../job/publish-build-assets.yml
parameters:
continueOnError: ${{ parameters.continueOnError }}
dependsOn:
- ${{ if ne(parameters.publishBuildAssetsDependsOn, '') }}:
- ${{ each job in parameters.publishBuildAssetsDependsOn }}:
- ${{ job.job }}
- ${{ if eq(parameters.publishBuildAssetsDependsOn, '') }}:
- ${{ each job in parameters.jobs }}:
- ${{ job.job }}
- ${{ if eq(parameters.enableSourceBuild, true) }}:
- Source_Build_Complete
pool:
# We don't use the collection uri here because it might vary (.visualstudio.com vs. dev.azure.com)
${{ if eq(variables['System.TeamProject'], 'DevDiv') }}:
name: VSEngSS-MicroBuild2022-1ES
demands: Cmd
# If it's not devdiv, it's dnceng
${{ if ne(variables['System.TeamProject'], 'DevDiv') }}:
name: NetCore1ESPool-Internal
demands: ImageOverride -equals windows.vs2019.amd64
runAsPublic: ${{ parameters.runAsPublic }}
publishUsingPipelines: ${{ parameters.enablePublishUsingPipelines }}
publishAssetsImmediately: ${{ parameters.publishAssetsImmediately }}
enablePublishBuildArtifacts: ${{ parameters.enablePublishBuildArtifacts }}
artifactsPublishingAdditionalParameters: ${{ parameters.artifactsPublishingAdditionalParameters }}
signingValidationAdditionalParameters: ${{ parameters.signingValidationAdditionalParameters }}
akoeplinger
added a commit
to dotnet/runtime-assets
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/node
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/node
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/cpython
that referenced
this pull request
Nov 8, 2023
akoeplinger
added a commit
to dotnet/cpython
that referenced
this pull request
Nov 8, 2023
ViktorHofer
pushed a commit
to dotnet/runtime-assets
that referenced
this pull request
Nov 8, 2023
…yml (#376) * Remove DotNet-Blob-Feed variable from eng/pipelines/common-variables.yml See dotnet/arcade#14188 * Remove legacy blob publish properties See dotnet/arcade#10372
akoeplinger
added a commit
to dotnet/cecil
that referenced
this pull request
Dec 12, 2023
akoeplinger
added a commit
to dotnet/cecil
that referenced
this pull request
Dec 12, 2023
akoeplinger
added a commit
to dotnet/cecil
that referenced
this pull request
Dec 12, 2023
akoeplinger
added a commit
to dotnet/cecil
that referenced
this pull request
Dec 12, 2023
radekdoulik
pushed a commit
to radekdoulik/llvm-project
that referenced
this pull request
May 9, 2024
akoeplinger
added a commit
to dotnet/llvm-project
that referenced
this pull request
May 17, 2024
radekdoulik
pushed a commit
to dotnet/llvm-project
that referenced
this pull request
Aug 16, 2024
radekdoulik
pushed a commit
to dotnet/llvm-project
that referenced
this pull request
Sep 2, 2024
radekdoulik
pushed a commit
to dotnet/llvm-project
that referenced
this pull request
Sep 12, 2024
radekdoulik
pushed a commit
to dotnet/llvm-project
that referenced
this pull request
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These properties don't have a use anywhere (DotNetPublishBlobFeedUrl and DotNetPublishBlobFeedKey) and are non-functional.
To double check: