Merged
Conversation
Member
|
Do you have a run where this commit was used to demonstrate this works? |
ghost
reviewed
Jul 19, 2022
Member
Author
Build 20220718.10 is a successful test run. It runs just the stages needed for SDL. (The SDL step "failed" because SDL ran and found issues, which is exactly what we want it to do.) |
This reverts commit 3883d79.
MattGal
approved these changes
Jul 19, 2022
jonfortescue
approved these changes
Jul 19, 2022
ghost
approved these changes
Jul 19, 2022
|
@garath, this seems to have broken the official build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1894173&view=logs&s=3df7d716-4c9c-5c26-9f45-11f62216640d&j=7d9eef18-6720-5c1f-4d30-89d7b76728e9 |
garath
added a commit
to garath/dotnet-arcade
that referenced
this pull request
Jul 21, 2022
This broke in main. This reverts commit 3439b16.
garath
added a commit
that referenced
this pull request
Jul 21, 2022
garath
added a commit
to garath/dotnet-arcade
that referenced
this pull request
Jul 26, 2022
…)" This reverts commit 3535001.
am11
pushed a commit
to am11/arcade
that referenced
this pull request
Jul 26, 2022
am11
pushed a commit
to am11/arcade
that referenced
this pull request
Jul 26, 2022
This broke in main. This reverts commit 3439b16.
garath
added a commit
that referenced
this pull request
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tweaks the SDL templates to fetch and use the "latest" Guardian version by default.
Resolves #8075