-
Notifications
You must be signed in to change notification settings - Fork 383
Comparing changes
Open a pull request
base repository: dotnet/arcade
base: e9cdc02
head repository: dotnet/arcade
compare: 1bfe912
- 8 commits
- 24 files changed
- 6 contributors
Commits on Apr 1, 2021
-
Fix failing unit tests in Arcade SDK and include them in CI test runs (…
…#7159) This commit re-enables `Microsoft.DotNet.Arcade.Sdk.Tests` project when during Helix test runs. Previously it was disabled because there were some problems with test environment on Helix. Additionally it fixes the following test failures: ### FindLatestDropTests `JObject.Parse` parses JSON dates as `DateTime` by default not as `string`. When we were calling `(string)item["CreatedDateUtc"]` the `DateTime` stored in that property was converted to string using invariant culture and then we tried to parse it back using current culture. It worked correctly as long as the date time formats for both cultures were the same but this is only true for `en-US`. I also converted `GetLatestDropName_Error` test to use `Theory` instead of having four asserts inside. This makes it easier to see which case actually failed. ### GenerateResxSourceTests The generation code was changed some time ago but the test data that we use as the expected output was not updated. I copied the current output of the generator and put it into test assets. Of course this assumes that the current output is correct but it looks like it is. ### GenerateSourcePackageSourceLinkTargetsFileTests The tests failed on Unix because some of the backslashes in test strings were converted to front slashes but not all. It was fixed by explicitly normalizing all paths before passing them to the tested code. ### MinimalRepoTests / RepoWithConditionalProjectsToBuildTests I had to mark these tests as skipped because they are not trivial to fix and they block us from enabling Arcade.SDK.Tests on CI builds. We should enable them back as soon as they are fixed. Related issue: #7092 ### To double check: * [X] The right tests are in and and the right validation has happened. Guidance: https://github.com/dotnet/core-eng/tree/master/Documentation/Validation
Łukasz Patalas authoredApr 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 3094b88 - Browse repository at this point
Copy the full SHA 3094b88View commit details -
[main] Update dependencies from dotnet/arcade dotnet/sourcelink mono/…
…linker (#7175) [main] Update dependencies from dotnet/arcade dotnet/sourcelink mono/linker
Configuration menu - View commit details
-
Copy full SHA for 612d26e - Browse repository at this point
Copy the full SHA 612d26eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b4d625 - Browse repository at this point
Copy the full SHA 0b4d625View commit details
Commits on Apr 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c564491 - Browse repository at this point
Copy the full SHA c564491View commit details -
Fix GenerateBuildManifest publish version parsing (#7167)
The `<GenerateBuildManifest/>` task was erroring every time the `PublishingVersion` input parameter was used. The `Enum.TryParse` success check has been fixed to prevent this. Additionally, some unused parameters have been removed from the task.
Configuration menu - View commit details
-
Copy full SHA for 8efbcc6 - Browse repository at this point
Copy the full SHA 8efbcc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7578ab9 - Browse repository at this point
Copy the full SHA 7578ab9View commit details -
Introduce CancelHelixJobs task to allow cancellation of Helix Jobs as…
…ynchronously by different pipelines / stages. (#7185)
Configuration menu - View commit details
-
Copy full SHA for af434ac - Browse repository at this point
Copy the full SHA af434acView commit details
Commits on Apr 3, 2021
-
Add SkipOnPlatform attribute to Microsoft.DotNet.XUnitExtensions (#7184)
* Add SkipOnPlatform attribute to Microsoft.DotNet.XUnitExtensions In dotnet/runtime we have a bunch of test assemblies that don't make sense on some platforms, e.g. Browser. Right now we're skipping them via `[SkipOnMono("reason", TestPlatforms.Browser)]` but there's nothing that inherently ties this to Mono other than the current implementation. Add a more generic SkipOnPlatform attribute that we can use instead. * PR feedbackConfiguration menu - View commit details
-
Copy full SHA for 1bfe912 - Browse repository at this point
Copy the full SHA 1bfe912View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e9cdc02...1bfe912