Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a7c57ab
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fecf65b
Choose a head ref
  • 11 commits
  • 29 files changed
  • 7 contributors

Commits on Nov 5, 2021

  1. Improve exception logging while publishing to blob storage (#8134)

    There can still be errors while uploading files to blob storage, even after confirming that the file doesn't already exist at the given location. See: https://dev.azure.com/dnceng/internal/_build/results?buildId=1443383&view=logs&j=8667c75e-c9c8-5a72-3326-7d35d151733c&t=648bbdf3-1356-5b63-95ae-560e1b5f90bf. Today, that exception is thrown, but since everything is async, it isn't clear what package was having an issue publishing.
    
    This change adds a try/catch around the call to UploadAsync, and will long the file name and blob path along with the exception message if UploadAsync throws an exception.
    michellemcdaniel authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    3b953c8 View commit details
    Browse the repository at this point in the history
  2. Use XHarness' diagnostics output to detect infrastructure issues (#8139)

    Instead of relying on the work item to request retry/reboot, we do it in the SDK at the end of the job while reading the `diagnostics.json` file generated by XHarness.
    This will transparently work for any number of XHarness commands executed during the work item and can be a single place for the logic. It also unifies the logic we had duplicated over the `.ps` and `.sh` files.
    The user then doesn't need to categorize or react on failed XHarness commands in any way.
    
    We still allow the users to request retry/reboot using the .dotfiles but it should not be necessary.
    premun authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    ebeeb85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2677562 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. Update arcade-validation steps (#7891)

    * Update arcade-validation steps
    
    * revert some part
    
    * review comments
    epananth authored Nov 6, 2021
    Configuration menu
    Copy the full SHA
    cfc0456 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Update dependencies from https://github.com/dotnet/roslyn build 20211…

    …105.3 (#8149)
    
    [main] Update dependencies from dotnet/roslyn
    dotnet-maestro[bot] authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    be5f628 View commit details
    Browse the repository at this point in the history
  2. [main] Update dependencies from dotnet/xharness dotnet/arcade (#8147)

    [main] Update dependencies from dotnet/xharness dotnet/arcade
    dotnet-maestro[bot] authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    2afca8f View commit details
    Browse the repository at this point in the history
  3. Allow the passing in of msbuildEngine to msbuild.ps1 (#8142)

    In repos that need to mix vs and dotnet msbuild engines, and use this script directly, we need to allow for the msbuildEngine to be passed in.
    michellemcdaniel authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    e408d72 View commit details
    Browse the repository at this point in the history
  4. Add missing MicrosoftSourceLinkVersion property definition (#8145)

    * Add missing MicrosoftSourceLinkVersion property definition
    
    * Update Versions.props
    tmat authored Nov 8, 2021
    Configuration menu
    Copy the full SHA
    0658506 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Shorten tool path when installing XHarness locally (#8160)

    The path was actually needlessly long which could cause problems with the `dotnet tool install` command
    
    The name of the package was repeated twice for no reason:
    
    > artifacts\tmp\Debug\Microsoft.DotNet.XHarness.CLI\Microsoft.DotNet.XHarness.CLI\1.0.0-prerelease.21558.2
    premun authored Nov 9, 2021
    1 Configuration menu
    Copy the full SHA
    4d41c8b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    740df59 View commit details
    Browse the repository at this point in the history
  3. Bring back non-Maestro.Client dependent pieces of Tasks.Feed for .NET…

    … 4.7.2, to allow usage from desktop msbuild. (#8158)
    MattGal authored Nov 9, 2021
    Configuration menu
    Copy the full SHA
    fecf65b View commit details
    Browse the repository at this point in the history
Loading