Improve exception logging while publishing to blob storage#8134
Merged
michellemcdaniel merged 1 commit intodotnet:mainfrom Nov 5, 2021
Merged
Improve exception logging while publishing to blob storage#8134michellemcdaniel merged 1 commit intodotnet:mainfrom
michellemcdaniel merged 1 commit intodotnet:mainfrom
Conversation
There can still be errors while uploading files to blob storage, even after confirming that the file doesn't already exist at the given location. See: https://dev.azure.com/dnceng/internal/_build/results?buildId=1443383&view=logs&j=8667c75e-c9c8-5a72-3326-7d35d151733c&t=648bbdf3-1356-5b63-95ae-560e1b5f90bf. Today, that exception is thrown, but since everything is async, it isn't clear what package was having an issue publishing. This change adds a try/catch around the call to UploadAsync, and will long the file name and blob path along with the exception message if UploadAsync throws an exception.
epananth
approved these changes
Nov 4, 2021
alexperovich
reviewed
Nov 4, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can still be errors while uploading files to blob storage, even after confirming that the file doesn't already exist at the given location. See: https://dev.azure.com/dnceng/internal/_build/results?buildId=1443383&view=logs&j=8667c75e-c9c8-5a72-3326-7d35d151733c&t=648bbdf3-1356-5b63-95ae-560e1b5f90bf. Today, that exception is thrown, but since everything is async, it isn't clear what package was having an issue publishing.
This change adds a try/catch around the call to UploadAsync, and will long the file name and blob path along with the exception message if UploadAsync throws an exception.
To double check: