Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/arcade
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 34bc5b1
Choose a base ref
...
head repository: dotnet/arcade
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7a7ba50
Choose a head ref
  • 10 commits
  • 24 files changed
  • 7 contributors

Commits on Jan 6, 2022

  1. Configuration menu
    Copy the full SHA
    24f759c View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. [main] Update dependencies from dotnet/arcade dotnet/sourcelink (#8324)

    [main] Update dependencies from dotnet/arcade dotnet/sourcelink
    dotnet-maestro[bot] authored Jan 7, 2022
    Configuration menu
    Copy the full SHA
    5208804 View commit details
    Browse the repository at this point in the history
  2. Remove support for v2 publishing in the templates (#8325)

    Part of the 1ES pool work would require moving a bunch of legacy, deprecated jobs to the 1ES pools for completeness. I see this as an opportunity to cut off v2 publishing, which should no longer be in use by anyone. While this is not a full removal from .NET Arcade's main, it removes the crucial templating support that enables repos to get into trouble.
    
    Benefits include:
    - Simplification of the templates - The allocation time on the 1ES pools will be signficantly longer. We may need to do work in the templates to mitigate this cost. Simplifying the templates will help in this effort
    - Keep people from accidentally using V2 - There have been a number of repos over the last few months found to still be using v2, and getting broken as a result of changes. V2 is no longer supported as of .NET 5. Removal should help with this.
    mmitche authored Jan 7, 2022
    Configuration menu
    Copy the full SHA
    65865aa View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. [main] Update dependencies from dotnet/xliff-tasks dotnet/xharness (#…

    …8328)
    
    [main] Update dependencies from dotnet/xliff-tasks dotnet/xharness
    dotnet-maestro[bot] authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    aa647dc View commit details
    Browse the repository at this point in the history
  2. Update dependencies from https://github.com/dotnet/roslyn build 20220…

    …103.6 (#8329)
    
    [main] Update dependencies from dotnet/roslyn
    dotnet-maestro[bot] authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    6c3d631 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Configuration menu
    Copy the full SHA
    2b11246 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Disable Workloads WiX dependency in source-build (#8335)

    Removes the dependency on WiX during source-build to prevent pulling in the WiX prebuilt binary: #8014
    
    Co-authored-by: Davis Goodin <dagood@microsoft.com>
    lbussell and dagood authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0de9a22 View commit details
    Browse the repository at this point in the history
  2. Streamline and simplify v3 publishing job (#8334)

    This change removes a bunch of cruft in the publishing job such that:
    - v2 is no longer supported, even incidentally (it's not been actually supported by Eng Services for some time, but the code has stuck around)
    - A single machine is used for publishing. This reduces the number of allocations, making it possible to move to 1ES pools (not in this change, yet). It also reduces general overhead associated with using multiple jobs and stages.
    
    Implementation is as follows:
    - Remove old, unused v3 publishing options and associated templates (nuget, source link and signing validation).
    - Collapse all publishing down into a single job that first looks up and validates the build and channel info, setting up any necessary variables for passing to the publish task.
    - Call the publish task with the associated parameters
    - Also fixes an issue where we were incorrectly passing IsInternalBuild. The value of that was being evaluated in the context of the arcade publishing job, not the actual build we were trying to promote. The value of this is just used for a safety check.
    - Remove publish installers and checksums options. This was hardcoded to true, and is legacy from when we were rolling this functionality out.
    mmitche authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    5de8a0a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7189b4a View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Detect network connectivity issue in Android devices (#8263)

    ### Context
    We often see Android devices losing their WiFi connection and going offline. In this case, we are still able to install apps via the USB cable and run most of the tests.
    
    Some of the test apps require internet though (such as `System.Net.*.Tests`) and no connectivity usually means the tests fail. From infrastructure point of view, we have no idea that there was this problem though.
    
    ### This change
    
    .. performs a network check from the device in case of any Android device failure and retries the work item on a different machine in case the WiFi connection is down.
    
    We also send telemetry event so that we learn about the device without connectivity.
    
    More details in #8232
    premun authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    7a7ba50 View commit details
    Browse the repository at this point in the history
Loading