Merged
Conversation
Member
Author
|
@ericstj @NikolaMilosavljevic I decided to make the smallest change possible. Alternatively, I could have just used the MajorUpgrade element that's available to WiX, but that's a larger change. |
Member
Author
|
cc @jonathanpeppers @pjcollins since this will eventually impact workload manifest generation |
NikolaMilosavljevic
approved these changes
Jan 10, 2022
ericstj
approved these changes
Jan 11, 2022
Member
ericstj
left a comment
There was a problem hiding this comment.
This looks reasonable to me. It removes the language constraint on the upgrade so it's unlikely to break anything, just make the upgrade apply more broadly. I can see how this fixes the issue described. Nice find.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Workload manifest installers currently configure the language column of the MSI upgrade table. When the MSI is included in a bundle and running under local SYSTEM, the bundle defaults to querying installed products against the user unmanaged context first. The
INSTALLPROPERTY_LANGUAGEcannot be queried in this context (see https://docs.microsoft.com/en-us/windows/win32/api/msi/nf-msi-msigetproductinfoexw)The logic in the setup engine reports the failure, but doesn't query the machine context and plans the MSI package for execution. When the planned MSI is a lower version than what's already installed, the engine fails to detect this. By allowing the MSI to execute, it then triggers the downgrade launch condition. The MSI terminates with 1603 as expected, but then the bundle rolls back and fails the overall install.
Fix
We don't need to set the language ID in the upgrade table and removing it will work around the error in Burn (bundle engine).