[Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app#7892
Merged
dellis1972 merged 1 commit intodotnet:mainfrom Mar 21, 2023
Merged
[Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app#7892dellis1972 merged 1 commit intodotnet:mainfrom
dellis1972 merged 1 commit intodotnet:mainfrom
Conversation
jonathanpeppers
approved these changes
Mar 17, 2023
… the app Fixes dotnet#7890 We found and issue where if you upgraded a NuGet Package it did not up date the assemblies in the `$(IntermediateOutputPath)android\assets` folder. We have a unit test which checks this particular scenario, but it was disabled on .net during the port to .net 6. We never got back to enable it. The issue it turns out is that NuGet not longer populates the `ProjectLockFile` property. As a result we never stored the `_NuGetAssetsTimestamp` in the `build.props` file. This causes the `_CleanIntermediateIfNeeded` target to be skipped when it really should run. Switching over to using the `ProjectAssetsFile` property to populate the `_NuGetAssetsTimestamp` property fixes the issue. Also the unit test was updated to work on both Legacy and .net.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Mar 22, 2023
* main: [docs] how to get gc dumps w/ `dotnet-trace` (dotnet#7875) [Xamarin.Android.Build.Tasks] Fix AndroidPackagingOptionsExclude (dotnet#7903) Bump to dotnet/installer@c373093 8.0.100-preview.3.23170.5 (dotnet#7901) [Xamarin.Android.Build.Tasks] Updating NuGet packages does not update the app (dotnet#7892) [vs-workload] Remove @(MultiTargetPackNames) (dotnet#7894)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7890
We found and issue where if you upgraded a NuGet Package it did not up date the assemblies in the
$(IntermediateOutputPath)android\assetsfolder. We have a unit test which checks this particular scenario, but it was disabled on .net during the port to .net 6. We never got back to enable it.The issue it turns out is that NuGet not longer populates the
ProjectLockFileproperty. As a result we never stored the_NuGetAssetsTimestampin thebuild.propsfile. This causes the_CleanIntermediateIfNeededtarget to be skipped when it really should run.Switching over to using the
ProjectAssetsFileproperty to populate the_NuGetAssetsTimestampproperty fixes the issue. Also the unit test was updated to work on both Legacy and .net.