Closed
Conversation
Context: #3155 The original attempt at bumping to mono/mono@da1fa28 is failing largely because the updated system mono 6.4.0 won't build the xamarin-android and Java.Interop repo's, seemingly because of new [issues within msbuild][0]. # within Java.Interop make all V=1 ... Building target "GenerateBuildDependencyFile" completely. Output file "/Users/jon/Dropbox/Developer/Java.Interop/bin/Debug/netstandard2.0/Java.Interop.deps.json" does not exist. Using "GenerateDepsFile" task from assembly "/usr/local/share/dotnet/sdk/2.1.505/Sdks/Microsoft.NET.Sdk/targets/../tools/net46/Microsoft.NET.Build.Tasks.dll". Task "GenerateDepsFile" /usr/local/share/dotnet/sdk/2.1.505/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018: The "GenerateDepsFile" task failed unexpectedly. /usr/local/share/dotnet/sdk/2.1.505/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(129,5): error MSB4018: System.MissingMethodException: Method not found: System.Collections.Generic.IList`1<NuGet.Packaging.Core.PackageDependency> NuGet.ProjectModel.LockFileTargetLibrary.get_Dependencies() ... In an attempt to expedite the bump, or at minimum see what other problems befall us, *drop* the system mono bump -- sticking with mono 6.0.0.6 for builds -- and *just* bump the mono submodule. This should allow the on-device tests to execute. [0]: #3155 (comment)
Merged
Contributor
Author
|
Didn't work: https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-release/1107/ Oddly, we get the ~same error building Cecil as we do in PR #3155: This doesn't immediately make sense to me. :-/ |
radekdoulik
added a commit
to radekdoulik/java.interop
that referenced
this pull request
Jun 4, 2019
When trying to use newer mono in XA, we run into issues where cecil (from mono repo) doesn't build anymore. Context: dotnet/android#3159 Turned out we need to restore nuget packages for cecil before the build to avoid errors like: Mono.Cecil/TypeSystem.cs(83,29): error CS0518: Predefined type 'System.Object' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj] Mono.Cecil/TypeSystem.cs(83,4): error CS0518: Predefined type 'System.Void' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj] Mono.Cecil/TypeSystem.cs(81,4): error CS0518: Predefined type 'System.Object' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj] 8 Warning(s) 7700 Error(s) Also grant access from `Mono.Cecil.[Mdb|Pdb]` assemblies to `Mono.Cecil`. Looks like the access restrictions got tighter and so CSC was complaining about the wrong key. It happens because the original cecil key differ from our `product.snk` key, which we add in our overrides and so access for `Mono.Cecil.[Mdb|Pdb]` granted by original cecil `AssemblyInfo.cs` file is not valid anymore. The error we were getting from CSC: CSC : error CS0281: Friend access was granted by 'Mono.Cecil, Version=0.11.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065', but the public key of the output assembly does not match that specified by the attribute in the granting assembly. [/Users/rodo/git/xa2/external/mono/external/cecil/symbols/mdb/Mono.Cecil.Mdb.csproj]
grendello
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Jun 4, 2019
When trying to use newer mono in XA, we run into issues where cecil (from mono repo) doesn't build anymore. Context: dotnet/android#3159 Turned out we need to restore nuget packages for cecil before the build to avoid errors like: Mono.Cecil/TypeSystem.cs(83,29): error CS0518: Predefined type 'System.Object' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj] Mono.Cecil/TypeSystem.cs(83,4): error CS0518: Predefined type 'System.Void' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj] Mono.Cecil/TypeSystem.cs(81,4): error CS0518: Predefined type 'System.Object' is not defined or imported [/Users/rodo/git/xa2/external/mono/external/cecil/Mono.Cecil.csproj] 8 Warning(s) 7700 Error(s) Also grant access from `Mono.Cecil.[Mdb|Pdb]` assemblies to `Mono.Cecil`. Looks like the access restrictions got tighter and so CSC was complaining about the wrong key. It happens because the original cecil key differ from our `product.snk` key, which we add in our overrides and so access for `Mono.Cecil.[Mdb|Pdb]` granted by original cecil `AssemblyInfo.cs` file is not valid anymore. The error we were getting from CSC: CSC : error CS0281: Friend access was granted by 'Mono.Cecil, Version=0.11.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065', but the public key of the output assembly does not match that specified by the attribute in the granting assembly. [/Users/rodo/git/xa2/external/mono/external/cecil/symbols/mdb/Mono.Cecil.Mdb.csproj]
As they changed after we migrated Java.Interop to C++
grendello
approved these changes
Jun 5, 2019
Contributor
Author
|
Closing as this avenue of investigation didn't pan out. Let's stick with PR #3155. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: #3155
The original attempt at bumping to mono/mono@da1fa28 is
failing largely because the updated system mono 6.4.0 won't build the
xamarin-android and Java.Interop repo's, seemingly because of new
issues within msbuild.
In an attempt to expedite the bump, or at minimum see what other
problems befall us, drop the system mono bump -- sticking with
mono 6.0.0.6 for builds -- and just bump the mono submodule. This
should allow the on-device tests to execute.