Skip to content

Fix outdated contents in WorkloadDependencies.json#10627

Merged
jonathanpeppers merged 4 commits intomainfrom
copilot/fix-workloaddependencies-json
Dec 8, 2025
Merged

Fix outdated contents in WorkloadDependencies.json#10627
jonathanpeppers merged 4 commits intomainfrom
copilot/fix-workloaddependencies-json

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025 •
edited
Loading

Updates the Android manifest feed reference in WorkloadDependencies.proj from d17-12 to Dev18 (d18-0) to fix outdated Android SDK versions in the generated WorkloadDependencies.json.

Problem

The WorkloadDependencies.json file was being generated with outdated Android SDK versions:

  • build-tools;35.0.0 instead of 36.x
  • platforms;android-35 instead of android-36

Root Cause

The feed URL in tools/workload-dependencies/WorkloadDependencies.proj was pointing to d17-12, which doesn't contain SDK 36 entries.

Changes Made

  • Updated the local file path from AndroidManifestFeed_d17.12.xml to AndroidManifestFeed_d18.0.xml
  • Updated the fallback URL from https://aka.ms/AndroidManifestFeed/d17-12 to https://aka.ms/AndroidManifestFeed/d18-0

The Dev18 (d18-0) feed contains the android-36 and android-36.1 platform entries needed for .NET 10.

Original prompt

This section details on the original issue you should resolve

<issue_title>WorkloadDependencies.json has wrong contents</issue_title>
<issue_description>### Android framework version

net10.0-android (Preview)

Affected platform version

Windows, but probably all

Description

Looking at:

C:\Program Files\dotnet\sdk-manifests\10.0.100\microsoft.net.sdk.android\36.1.2\WorkloadDependencies.json

It says:

        {
          "desc": "Android SDK Build-Tools 35",
          "sdkPackage": {
            "id": "build-tools;35.0.0"
          },
          "optional": "false"
        },
...
        {
          "desc": "Android SDK Platform 35",
          "sdkPackage": {
            "id": "platforms;android-35"
          },
          "optional": "false"
        },

It feels like a lot of these numbers are outdated and should be 36.x?

Steps to Reproduce

dotnet workload install android

Did you find any workaround?

No response

Relevant log output

```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI requested a review from jonathanpeppers December 3, 2025 23:06
@jonathanpeppers
Copy link
Member

jonathanpeppers commented Dec 5, 2025

@copilot try again

@jonathanpeppers
Update Android SDK feed reference from d17-12 to d17-14
773aec0 
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 5, 2025

@copilot try again

Updated the Android manifest feed reference from d17-12 to d17-14 in WorkloadDependencies.proj (773aec0). The d17-14 feed contains the android-36 platform entry needed for .NET 10.

Copilot AI changed the title [WIP] Fix outdated contents in WorkloadDependencies.json Fix outdated contents in WorkloadDependencies.json Dec 5, 2025
@jonathanpeppers jonathanpeppers marked this pull request as ready for review December 5, 2025 23:41
jonathanpeppers
jonathanpeppers approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, but we should check CI is green. (it's ongoing)

jonathanpeppers
jonathanpeppers reviewed Dec 8, 2025
View reviewed changes
@jonathanpeppers
Update Android SDK feed reference to Dev18 (d18-0)
b9ec78e 
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI requested a review from jonathanpeppers December 8, 2025 17:35
@jonathanpeppers
Copy link
Member

jonathanpeppers commented Dec 8, 2025

I see correct values now:

        {
          "desc": "Android SDK Platform 36",
          "sdkPackage": {
            "id": "platforms;android-36"
          },
          "optional": "false"
        },

@jonathanpeppers
Copy link
Member

jonathanpeppers commented Dec 8, 2025

This file is unused by our build, so not going to rerun some of the flaky test lanes. Merging.

@jonathanpeppers jonathanpeppers merged commit fa1d0c0 into main Dec 8, 2025
53 of 60 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-workloaddependencies-json branch December 8, 2025 20:42
jonathanpeppers added a commit that referenced this pull request Dec 8, 2025
@jonathanpeppers
Fix outdated contents in WorkloadDependencies.json (#10627)
2e0949e 
Fixes: #10596

- Updated the local file path from `AndroidManifestFeed_d17.12.xml`
   to `AndroidManifestFeed_d18.0.xml`

- Updated the fallback URL from `https://aka.ms/AndroidManifestFeed/d17-12`
   to `https://aka.ms/AndroidManifestFeed/d18-0`

The Dev18 (`d18-0`) feed contains the `android-36` and `android-36.1`
platform entries needed for .NET 10.

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@grendello grendello grendello approved these changes

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers jonathanpeppers is a code owner

Assignees

@jonathanpeppers jonathanpeppers

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WorkloadDependencies.json has wrong contents

3 participants

@jonathanpeppers @grendello