Skip to content

logging with dot on linux /7#30298

Merged
Rick-Anderson merged 2 commits into
mainfrom
loggingDot
Sep 11, 2023
Merged

logging with dot on linux /7#30298
Rick-Anderson merged 2 commits into
mainfrom
loggingDot

Conversation

@Rick-Anderson

@Rick-Anderson Rick-Anderson commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

Fixes #30294


Internal previews

📄 File 🔗 Preview link
aspnetcore/fundamentals/logging/index.md Logging in .NET Core and ASP.NET Core

@Rick-Anderson Rick-Anderson marked this pull request as ready for review September 11, 2023 22:02
@Rick-Anderson

Copy link
Copy Markdown
Contributor Author

@tdykstra can't make the note an include (at least easily) because
this on a similar page in the .NET documentation.

@Rick-Anderson Rick-Anderson merged commit 0add3a0 into main Sep 11, 2023
@Rick-Anderson Rick-Anderson deleted the loggingDot branch September 11, 2023 22:27
Rick-Anderson added a commit that referenced this pull request Sep 11, 2023
* secure swag (#30299)

* logging with dot on linux /7 (#30298)

* logging with dot on linux /7

* logging with dot on linux /7

* Update http-files.md (#30301)

Fixes #30293

---------

Co-authored-by: Rick Anderson <3605364+Rick-Anderson@users.noreply.github.com>
@tdykstra

Copy link
Copy Markdown
Contributor

@tdykstra can't make the note an include (at least easily) because this on a similar page in the .NET documentation.

It's probably not worth making dotnet/docs a dependent repo, but if all you need to do is make sure both are updated in sync with each other, you could add <!-- --> comments in each, pointing to the other.

@mmarinchenko

Copy link
Copy Markdown
Contributor

I apologize for writing this after the issue has been resolved. But this note only makes sense in the context of Unix shells. In the .NET documentation, it is located on the corresponding tab (named "Bash").

In the ASP.NET Core documentation there is no such tab, so it is necessary to add a clarification, similar to the one indicated above in the text, about the colon and double underscore. Otherwise, it turns out that the note is located outside the context in relation to which it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding a note about dot (.) symbols in the environment variable names

3 participants