Skip to content

Remove communication-layer-pub-sub crate#1145

Merged
haixuanTao merged 1 commit intomainfrom
rm-pubsub-communication-layer
Sep 25, 2025
Merged

Remove communication-layer-pub-sub crate#1145
haixuanTao merged 1 commit intomainfrom
rm-pubsub-communication-layer

Conversation

@phil-opp
Copy link
Copy Markdown
Collaborator

The crate is currently unused and depends on a very old zenoh version. Updating it to the current zenoh version would be some work and a breaking change (e.g. as zenoh::pubsub::Publisher is no longer Clone). So it's better to remove it for now.

This fixes some security alerts for our repo that are caused by the outdated zenoh dependency.

The crate is currently unused and depends on a very old zenoh version. Updating it to the current `zenoh` version would be some work and a breaking change (e.g. as `zenoh::pubsub::Publisher` is no longer `Clone`). So it's better to remove it for now.
@phil-opp phil-opp requested a review from haixuanTao September 25, 2025 09:29
@haixuanTao haixuanTao merged commit 7d7fa29 into main Sep 25, 2025
26 of 27 checks passed
@haixuanTao haixuanTao deleted the rm-pubsub-communication-layer branch September 25, 2025 12:23
phil-opp added a commit that referenced this pull request Sep 25, 2025
After merging #1145 and #1146, some additional dependencies are no longer needed. This commit updates the Cargo.lock to remove them, as done automatically by cargo.
@phil-opp phil-opp mentioned this pull request Sep 25, 2025
haixuanTao added a commit that referenced this pull request Sep 25, 2025
After merging #1145 and #1146, some additional dependencies are no
longer needed. This commit updates the Cargo.lock to remove them, as
done automatically by cargo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants