Fix fsck use earl.Parse to correctly resolve database path cross-platform#10915
Merged
Conversation
Contributor
|
@elianddb DOLT
|
133b7aa to
1a52746
Compare
Contributor
Contributor
earl.Parse to correctly resolve database path cross-platformfsck use earl.Parse to correctly resolve database path cross-platform
This was referenced Apr 24, 2026
Closed
Closed
seanmartinsmith
added a commit
to seanmartinsmith/beads
that referenced
this pull request
Apr 24, 2026
prePushFSCK previously wrapped any dolt fsck error as ErrDanglingReference with 'aborting push to prevent propagating corrupt chunks', including cases where fsck could not even open the database (environmental / tooling issues, not integrity problems). This misled users into thinking their healthy databases were corrupt. Concrete example: dolthub/dolt#10915 (Windows url.Parse bug, pre-v1.86.4) caused fsck to construct a malformed file path and fail to open; users hitting this saw the misleading 'dangling chunk reference' error from bd. Now detect the two known 'couldn't open' signatures from dolt and log a warning instead of aborting. Real integrity failures (dangling chunks in an openable db) still abort as before. Fixes gastownhall#3464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fsck.gowas usingurl.Parseto parse the database file URL. On Windows,url.Parseplaces the drive letter into the URL Host field rather than Path, causingdbfactory/file.goto construct an invalid file path.