Skip to content

Combine consecutive unsets#6909

Merged
Majkl578 merged 1 commit intodoctrine:developfrom
carusogabriel:combine_consecutive_unsets
Jan 2, 2018
Merged

Combine consecutive unsets#6909
Majkl578 merged 1 commit intodoctrine:developfrom
carusogabriel:combine_consecutive_unsets

Conversation

@carusogabriel
Copy link
Copy Markdown
Contributor

unset allow us to pass multiple values to check.

PHP-CS-Fixer helped me on that.

@Ocramius Ocramius self-assigned this Dec 19, 2017
@Ocramius Ocramius added this to the 3.0 milestone Dec 19, 2017
@Ocramius
Copy link
Copy Markdown
Member

@carusogabriel something went wrong with the test suite here - can you check it and see if that's because of this patch?

@Ocramius Ocramius assigned carusogabriel and unassigned Ocramius Dec 19, 2017
@Ocramius Ocramius removed this from the 3.0 milestone Dec 19, 2017
@carusogabriel
Copy link
Copy Markdown
Contributor Author

Gonna compare to the previous Travis CI and see what I missed 😅

@Majkl578
Copy link
Copy Markdown
Contributor

@Ocramius develop is failing permanently, nothing wrong there, at least until #6903. But as I already said, I'm not really sold here, it's worse to read.

@carusogabriel carusogabriel changed the title Conbine consecutive unsets Combine consecutive unsets Dec 20, 2017
Copy link
Copy Markdown
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Majkl578 Majkl578 merged commit a064d9f into doctrine:develop Jan 2, 2018
@Majkl578 Majkl578 assigned Majkl578 and unassigned carusogabriel Jan 2, 2018
@Majkl578 Majkl578 added this to the 3.0 milestone Jan 2, 2018
@carusogabriel carusogabriel deleted the combine_consecutive_unsets branch January 2, 2018 18:57
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants