Skip to content

Travis: Allow failures for tests on non-SQLite RDBMS, disable SLC tests#6903

Merged
Majkl578 merged 2 commits intodoctrine:masterfrom
Majkl578:dev/ci-disable-tests
Jan 27, 2018
Merged

Travis: Allow failures for tests on non-SQLite RDBMS, disable SLC tests#6903
Majkl578 merged 2 commits intodoctrine:masterfrom
Majkl578:dev/ci-disable-tests

Conversation

@Majkl578
Copy link
Copy Markdown
Contributor

Disable everything except SQLite on SLC=0. Because these simply don't work in develop at this stage. Also silent b0rked embedded.
Trying to make CI at least a bit useful for now.

Also bumbed PHPUnit version, older were was confused by Generator.

@Majkl578 Majkl578 added this to the 3.0 milestone Dec 18, 2017
@Majkl578
Copy link
Copy Markdown
Contributor Author

This now fails on PHPStan check due to errors in code - void return returns, LSP violations.

.travis.yml Outdated
#
# - stage: Test
# env: DB=mysql MYSQL_VERSION=5.7
# php: 7.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we remove PHP 7.1 from develop?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but @guilhermeblanco lost that commit during recent rebase. We should re-apply it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

},
"require-dev": {
"phpunit/phpunit": "^6.0"
"phpunit/phpunit": "^6.5"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump this on master? Pleaaaaaase!!!

@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch from 96dcde9 to d90a810 Compare January 1, 2018 19:45
@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch 5 times, most recently from 19c55f8 to d268de7 Compare January 2, 2018 18:02
@Majkl578 Majkl578 changed the base branch from develop to master January 2, 2018 20:29
@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch from d268de7 to 0663051 Compare January 12, 2018 20:50
@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch from 0663051 to 0fe26ca Compare January 27, 2018 05:28
@Majkl578 Majkl578 changed the title Travis: Disable tests on non-SQLite RDBMS and SLC Travis: Allow failures for tests on non-SQLite RDBMS, disable SLC tests Jan 27, 2018
@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch from 0fe26ca to c3431ef Compare January 27, 2018 05:40
@Majkl578
Copy link
Copy Markdown
Contributor Author

Although I'm not a fan of this approach in particular, I'll merge it as is so we can at least get relevant CI output for basic tests + Code Quality for the time being. We already got some bugs slipped through...
I'll start fixing PHPStan and CS builds later today - once done, we can require green Travis for PRs again.

Fixing SLC and non-SQLite tests will require additional effort at later stage. Hopefully we'll be able to re-enable those soon.

@Majkl578 Majkl578 assigned Majkl578 and unassigned guilhermeblanco Jan 27, 2018
@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch from c3431ef to 68c0357 Compare January 27, 2018 05:56
@Majkl578 Majkl578 force-pushed the dev/ci-disable-tests branch from 68c0357 to 13f173a Compare January 27, 2018 06:13
@Majkl578 Majkl578 merged commit ee4e267 into doctrine:master Jan 27, 2018
@Majkl578 Majkl578 deleted the dev/ci-disable-tests branch January 27, 2018 06:41
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants