Merged
Conversation
greg0ire
approved these changes
Nov 29, 2025
Member
greg0ire
left a comment
There was a problem hiding this comment.
Code looks good, but you know what I think about treating this like a bugfix. In addition to this, merging this up to 3.5 when you contributed sf8 support to 3.6 makes little sense. Still, I'm approving because I don't want the sf hackathon momentum to get lost.
Member
Author
|
I'll merge it up to 3.5, but the whole trait will be gone there. |
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 29, 2025
* 2.20.x: Support Symfony Console 8 (doctrine#12300) Bump doctrine/.github/.github/workflows/composer-lint.yml (doctrine#12288) Bump doctrine/.github/.github/workflows/documentation.yml (doctrine#12289) Bump doctrine/.github/.github/workflows/coding-standards.yml (doctrine#12290) Bump doctrine/.github/.github/workflows/release-on-milestone-closed.yml (doctrine#12291) Bump actions/checkout from 5 to 6 (doctrine#12292)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 29, 2025
* 3.5.x: Removes Guides from our dependencies (doctrine#12303) Fix PHPStan and test errors after DBAL 4.4 and Symfony 7.4 releases (doctrine#12301) Support Symfony Console 8 (doctrine#12300) Bump doctrine/.github/.github/workflows/composer-lint.yml (doctrine#12288) Bump doctrine/.github/.github/workflows/documentation.yml (doctrine#12289) Bump doctrine/.github/.github/workflows/coding-standards.yml (doctrine#12290) Bump doctrine/.github/.github/workflows/release-on-milestone-closed.yml (doctrine#12291) Bump actions/checkout from 5 to 6 (doctrine#12292)
derrabus
added a commit
that referenced
this pull request
Nov 29, 2025
* 3.5.x: Explicitly set a cache in testDisablingXmlValidationIsPossible (#12307) Removes Guides from our dependencies (#12303) Fix PHPStan and test errors after DBAL 4.4 and Symfony 7.4 releases (#12301) Support Symfony Console 8 (#12300) Bump doctrine/.github/.github/workflows/composer-lint.yml (#12288) Bump doctrine/.github/.github/workflows/documentation.yml (#12289) Bump doctrine/.github/.github/workflows/coding-standards.yml (#12290) Bump doctrine/.github/.github/workflows/release-on-milestone-closed.yml (#12291) Bump actions/checkout from 5 to 6 (#12292)
derrabus
added a commit
that referenced
this pull request
Nov 29, 2025
* 3.5.x: Remove obsolete VarExporter feature detection (#12309) Allow Symfony 8 (#12308) Explicitly set a cache in testDisablingXmlValidationIsPossible (#12307) Removes Guides from our dependencies (#12303) Fix PHPStan and test errors after DBAL 4.4 and Symfony 7.4 releases (#12301) Support Symfony Console 8 (#12300) Bump doctrine/.github/.github/workflows/composer-lint.yml (#12288) Bump doctrine/.github/.github/workflows/documentation.yml (#12289) Bump doctrine/.github/.github/workflows/coding-standards.yml (#12290) Bump doctrine/.github/.github/workflows/release-on-milestone-closed.yml (#12291) Bump actions/checkout from 5 to 6 (#12292)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 30, 2025
* 3.6.x: Remove obsolete PHPStan ignore rules Remove obsolete VarExporter feature detection (doctrine#12309) Allow Symfony 8 (doctrine#12308) Explicitly set a cache in testDisablingXmlValidationIsPossible (doctrine#12307) Removes Guides from our dependencies (doctrine#12303) Fix PHPStan and test errors after DBAL 4.4 and Symfony 7.4 releases (doctrine#12301) Support Symfony Console 8 (doctrine#12300) Bump doctrine/.github/.github/workflows/composer-lint.yml (doctrine#12288) Bump doctrine/.github/.github/workflows/documentation.yml (doctrine#12289) Bump doctrine/.github/.github/workflows/coding-standards.yml (doctrine#12290) Bump doctrine/.github/.github/workflows/release-on-milestone-closed.yml (doctrine#12291) Bump actions/checkout from 5 to 6 (doctrine#12292) Add ORDER BY clause to more test cases Fix check for composite foreign key Fix documentation about default values Fix eager fetch composite foreign key (doctrine#11397)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.