Add ORDER BY clause to SELECT query#12222
Merged
SenseException merged 1 commit intodoctrine:3.5.xfrom Oct 12, 2025
Merged
Conversation
The order of results is not guaranteed unless we do so, and the test can fail in some cases: There was 1 failure: 1) Doctrine\Tests\ORM\Functional\QueryTest::testToIterableWithMixedResultArbitraryJoinsScalars Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'Doctrine 2' +'lala 2' /home/runner/work/orm/orm/tests/Tests/ORM/Functional/QueryTest.php:481
SenseException
approved these changes
Oct 12, 2025
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Nov 23, 2025
In doctrine#12222, I thought wrongly thought the issue I was fixing only affected one test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order of results is not guaranteed unless we do so, and the test can fail in some cases:
Spotted in https://github.com/doctrine/orm/actions/runs/18431080849/job/52518538835?pr=12221