The commits would need to be squashed either by you or the person who merges.

Thanks @mpdude

Hi,
Have you considered following code $repository->findBy(['uuid' => []]?

In version 2.20.6 it generates the following SQL

SELECT ...  FROM table t0 WHERE t0.uuid IN (NULL) 

But 2.20.7 generates invalid SQL

SELECT ...  FROM table t0 WHERE t0.uuid IN () 

This may be very surprising after update to a patch version, especially when the value is passed as a variable from another part of the application.

Hm, seems this was not covered by the existing test suite ☹️.

IN (NULL) is probably always false, right?

So, should passing an empty array mean that we want a false condition (like 1=0), and passing a null value in the array means to use x IN (…) OR x IS NULL?

Yes, IN (NULL) is always false.
We may debate whether it makes sense in terms of SQL. But the harsh fact is that it is really easy to write something like

public function getByIds(array $ids): array
{
    return $this->getRepository()->findBy(['id' => $ids]);
}

I would expect this code to return no results (as it's not changing the existing behavior).

So, should passing an empty array mean that we want a false condition (like 1=0), and passing a null value in the array means to use x IN (…) OR x IS NULL?

Yes, that summarizes it very well 💚

Hi, Have you considered following code $repository->findBy(['uuid' => []]?

In version 2.20.6 it generates the following SQL

SELECT ...  FROM table t0 WHERE t0.uuid IN (NULL) 

But 2.20.7 generates invalid SQL

SELECT ...  FROM table t0 WHERE t0.uuid IN () 

This may be very surprising after update to a patch version, especially when the value is passed as a variable from another part of the application.

This is definitely a breaking change. We have a few cases where we use that and a patch version should not introduce a breaking change. Changing from 3.5.2 to 3.5.3 breaks out projects badly because of this.

It means we have to go in every case where we use IN() and add a if ([] === $argument) {...} because if this.

This breaks a custom type on the convertToDatabaseValue method because instead of receiving an array ['my value'] it's now receiving plain string 'my value'.

This is when doing a findOneBy(['field' => ['my value']]);

Any pointers on how to fix this would be appreciated 🙏🏼 . For now I've reverted to 3.5.2