Skip to content

adapt assertions for new consistent PRIMARY KEY formatting#11883

Merged
greg0ire merged 1 commit intodoctrine:3.3.xfrom
xabbuh:dbal-6864
Mar 24, 2025
Merged

adapt assertions for new consistent PRIMARY KEY formatting#11883
greg0ire merged 1 commit intodoctrine:3.3.xfrom
xabbuh:dbal-6864

Conversation

@xabbuh
Copy link
Copy Markdown
Member

@xabbuh xabbuh commented Mar 24, 2025

related to doctrine/dbal#6864

greg0ire
greg0ire previously approved these changes Mar 24, 2025
@greg0ire greg0ire modified the milestone: 3.4.0 Mar 24, 2025
@greg0ire
Copy link
Copy Markdown
Member

Does this not affect lower branches?

@xabbuh
Copy link
Copy Markdown
Member Author

xabbuh commented Mar 24, 2025

@greg0ire What is the oldest maintained branch I could point this PR at? Is it 3.3.x?

@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Mar 24, 2025

Yes 👍

See #11208

(2.x makes no sense because it does not support DBAL 4, and probably never will)

@greg0ire greg0ire changed the base branch from 3.4.x to 3.3.x March 24, 2025 20:40
@greg0ire greg0ire added this to the 3.3.3 milestone Mar 24, 2025
@greg0ire greg0ire merged commit d883713 into doctrine:3.3.x Mar 24, 2025
80 checks passed
@greg0ire
Copy link
Copy Markdown
Member

Thanks @xabbuh !

@xabbuh xabbuh deleted the dbal-6864 branch March 24, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants