Use consistent formatting in PRIMARY KEY DDL#6864
Merged
morozov merged 1 commit intodoctrine:4.3.xfrom Mar 21, 2025
Merged
Conversation
greg0ire
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
PRIMARY KEY (...)DDL is inconsistently formatted across the codebase. The open parenthesis is sometimes padded with space:dbal/src/Platforms/AbstractPlatform.php
Line 1218 in 724c452
dbal/src/Platforms/AbstractPlatform.php
Line 1032 in 724c452
When it comes to refactoring this code and reusing one implementation in another, some unit tests start failing because of the changes in formatting.
Let's consistently use padding. This is consistent with the
CREATE TABLE <name> (...),FOREIGN KEY (...)andCHECK (...)formatting:dbal/src/Platforms/AbstractPlatform.php
Line 1041 in c7fafd7
dbal/src/Platforms/AbstractPlatform.php
Line 1744 in c7fafd7
dbal/src/Platforms/AbstractPlatform.php
Line 1562 in c7fafd7