Skip to content

[DDC-551] fix, add filter support in oneToOne relation 3.3.x#11708

Closed
jorenMartens wants to merge 1 commit intodoctrine:3.3.xfrom
jorenMartens:3.3.x
Closed

[DDC-551] fix, add filter support in oneToOne relation 3.3.x#11708
jorenMartens wants to merge 1 commit intodoctrine:3.3.xfrom
jorenMartens:3.3.x

Conversation

@jorenMartens
Copy link
Copy Markdown
Contributor

@jorenMartens jorenMartens commented Nov 7, 2024

Filters weren't applied for oneToOne relations
2.20.x PR -> #11707

#5664 can also be closed when this is merged
Maybe fixes #6343 (did not test)

@jorenMartens jorenMartens changed the title [DDC-551] fix, add filter support in oneToOne relation [DDC-551] fix, add filter support in oneToOne relation 3.3.x Nov 7, 2024
@esserj
Copy link
Copy Markdown

esserj commented Nov 7, 2024

Nice, finally a fix for this, filtering the join from the inverse side also makes to much more sense then from the mapped side. Especially when dealing with soft deletable filtering

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2025

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

@github-actions github-actions bot added the Stale label Feb 6, 2025
@esserj
Copy link
Copy Markdown

esserj commented Feb 6, 2025

Any chance this can be looked at?
Thanks in advance!

@greg0ire
Copy link
Copy Markdown
Member

greg0ire commented Feb 6, 2025

Closing in favor of #11707

@greg0ire greg0ire closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter on JOIN

3 participants