[DDC-551] fix, add filter support in oneToOne relation 2.20.x#11707
Merged
greg0ire merged 1 commit intodoctrine:2.20.xfrom Feb 7, 2025
Merged
[DDC-551] fix, add filter support in oneToOne relation 2.20.x#11707greg0ire merged 1 commit intodoctrine:2.20.xfrom
greg0ire merged 1 commit intodoctrine:2.20.xfrom
Conversation
Contributor
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
Any chance this can be looked at? |
Member
|
The CI has evolved, let's close and reopen to create a new merge commit and see if the new CI still passes. |
greg0ire
reviewed
Feb 6, 2025
|
|
||
| $user2 = $this->_em->find(CmsUser::class, $this->userId2); | ||
| self::assertEmpty($user2->address); | ||
| } |
Member
There was a problem hiding this comment.
This test fails when I revert the change in src, so, it is valid 👍
greg0ire
approved these changes
Feb 6, 2025
SenseException
approved these changes
Feb 6, 2025
Member
|
Thanks @jorenMartens ! |
|
Thanks @greg0ire , really appreciate it! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters weren't applied for oneToOne relations
3.3.x PR -> #11708
Closes #5664
Maybe fixes #6343 (did not test)