BUG: When changing SQLFilter parameter, resulting SQL query is not generated correctly#11694
Merged
greg0ire merged 1 commit intodoctrine:2.20.xfrom Oct 23, 2024
Conversation
6d81376 to
b3735ef
Compare
greg0ire
reviewed
Oct 22, 2024
Member
|
Please improve your commit message according to the contributing guide. Most notably, please describe the bug, and explain how your changes address the issue. |
daad5e4 to
3717654
Compare
greg0ire
previously approved these changes
Oct 22, 2024
3717654 to
210ba6e
Compare
SenseException
previously approved these changes
Oct 22, 2024
Member
|
🤔 why is this targeting 2.21.x? |
Contributor
Author
|
@greg0ire I don't know which branch to merge into |
Member
|
Take a look at #11208 |
…ters CachedPersisterContext::$selectJoinSql should be clear or regenerated when sqlFilter changed The problem reproduce when in use fetch=EAGER and use additional sql filter on this property
210ba6e to
439b4da
Compare
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
Closed
Contributor
Author
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
Oct 23, 2024
dbannik
pushed a commit
to dbannik/orm
that referenced
this pull request
Jan 21, 2025
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
dbannik
pushed a commit
to dbannik/orm
that referenced
this pull request
Jan 27, 2025
The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
May 5, 2025
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
May 5, 2025
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
May 5, 2025
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
dbannik
added a commit
to dbannik/orm
that referenced
this pull request
May 5, 2025
This fix takes into account the invalidation of the filter sql for SingleTablePersister and JoinedSubclassPersister
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
May 15, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
May 31, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Jun 24, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Jul 1, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Jul 5, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Jul 27, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Aug 27, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Aug 29, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Sep 10, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Oct 12, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Oct 23, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Nov 11, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Nov 19, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Nov 25, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Nov 29, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Dec 3, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Dec 16, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Dec 22, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Dec 31, 2025
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Jan 9, 2026
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
rotdrop
added a commit
to rotdrop/orm
that referenced
this pull request
Feb 28, 2026
Previously, new aliases were allocated for each association, but the index-by cache would just pick the first alias ever used. Fix this but not allocating a new alias for an already used join-column. See also: commit 6755bb0 Author: Bob van de Vijver <bobvandevijver@hotmail.com> Date: Wed Jan 8 10:38:23 2025 +0100 Fix Hydration when use ManyToMany[indexBy] The bug related (doctrine#11694) and fixed mapping of sql column alias to field in entity (doctrine#11783) and invalidate cache [cache/persisted/entity|cache/persisted/collection] when sql filter changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is not correctly generated sql when changed/switched sqlFilter parameters
CachedPersisterContext::$selectJoinSqlshould be clear or regenerated when sqlFilter changedThe problem reproduce when in use
fetch=EAGERand use additional sql filter on this property