Skip to content

[Embeddables] Improved exception message#1133

Closed
phansys wants to merge 1 commit intodoctrine:masterfrom
phansys:embeddables
Closed

[Embeddables] Improved exception message#1133
phansys wants to merge 1 commit intodoctrine:masterfrom
phansys:embeddables

Conversation

@phansys
Copy link
Copy Markdown
Contributor

@phansys phansys commented Sep 12, 2014

Improved exception message when embeddable definition is missing 'class' attribute.
Instead of:

The class '' was not found in the chain configured namespaces ...

It shows:

The embed mapping 'embeddedname' misses the 'class' attribute.

@doctrinebot
Copy link
Copy Markdown

doctrinebot commented Sep 12, 2014

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3305

We use Jira to track the state of pull requests and the versions they got
included in.

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Sep 12, 2014

@phansys looking good to me, but is it possible to add a unit test to it?

@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented Sep 12, 2014

Of course @Ocramius. I'll update this PR with new tests.
Thank you!

deeky666
deeky666 reviewed Sep 12, 2014
View reviewed changes
lib/Doctrine/ORM/Mapping/ClassMetadataFactory.php
Copy link
Copy Markdown
Member

@deeky666 deeky666 Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put spaces around !.

@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Nov 11, 2014

@phansys ping?

@Ocramius Ocramius self-assigned this Nov 11, 2014
@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented Nov 11, 2014

Hi @Ocramius.
Sorry for the timeout, I was very busy these weeks.
I was trying to figure out how to get working tests for this validation honoring the already existing tests, but I found some troubles because the schema in these tests are based on annotations and it is marked as invalid earlier than this check.
If you can, any clue is welcome.
Thank you!

Ocramius added a commit that referenced this pull request Jan 16, 2015
@Ocramius
#1133 DDC-3305 - test case with embeddable without referenced embedda…
7e4dab1 
…ble class
Ocramius added a commit that referenced this pull request Jan 16, 2015
@Ocramius
#1133 DDC-3305 - minor cs fix (spacing)
935a79e
@Ocramius Ocramius closed this in f28654d Jan 16, 2015
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jan 16, 2015

I rebased, applied tests and merged this into master at f28654d

Thanks @phansys!

@phansys
Copy link
Copy Markdown
Contributor Author

phansys commented Jan 16, 2015

Thank you @Ocramius.

@phansys phansys deleted the embeddables branch July 15, 2015 14:38
This was referenced Dec 6, 2015
Closed
Closed
@beberlei beberlei mentioned this pull request May 31, 2021
Merged
@greg0ire greg0ire mentioned this pull request Jan 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@phansys @doctrinebot @Ocramius @deeky666