[DBAL-1016] Fix explicitly quoted table identifiers in ALTER TABLE statements#700
Merged
Ocramius merged 1 commit intodoctrine:masterfrom Oct 21, 2014
Merged
[DBAL-1016] Fix explicitly quoted table identifiers in ALTER TABLE statements#700Ocramius merged 1 commit intodoctrine:masterfrom
Ocramius merged 1 commit intodoctrine:masterfrom
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1016 We use Jira to track the state of pull requests and the versions they got |
Member
There was a problem hiding this comment.
@deeky666 this is a minor BC break and should be documented
Member
There was a problem hiding this comment.
Nvm, it's not in 2.4, therefore not a BC break.
Member
|
Overall 👍, but needs docs on the minor BC break |
Ocramius
added a commit
that referenced
this pull request
Oct 21, 2014
[DBAL-1016] Fix explicitly quoted table identifiers in ALTER TABLE statements
This was referenced Dec 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another improvement to the neverending quotation issues.
This patch fixes explicitly quoted table identifiers in
ALTER TABLEstatements.Additionally some minor fixes had to be applied such as misc fixing of foreign key constraint statements order in the sequence of statements necessary to alter a table.