Enable platformOptions to be considered for ColumnDiff (PostgreSQL jsonb support)#6693
Merged
derrabus merged 2 commits intodoctrine:4.2.xfrom Jan 6, 2025
Merged
Conversation
…eSQLPlatform to utilize this new option, add tests around add jsonb option to a json column
derrabus
reviewed
Jan 6, 2025
Contributor
Author
|
@derrabus regarding tests: It seems my functional test for the Not sure if I should add this to other platforms aswell as I'm not sure which |
…case from general ComparatorTest class to the PostgreSQL dedicated one. Fix cs
97a9c02 to
db3b402
Compare
derrabus
approved these changes
Jan 6, 2025
Member
|
Thank you! |
derrabus
added a commit
that referenced
this pull request
Jan 6, 2025
* 4.2.x: Enable platformOptions to be considered for ColumnDiff (PostgreSQL jsonb support) (#6693)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 6, 2025
* 4.3.x: Enable platformOptions to be considered for ColumnDiff (PostgreSQL jsonb support) (doctrine#6693) Ignore new PHPStan errors Cleanup obsolete PHPStan ignore rules (doctrine#6697) Add a `NumberType` that maps to the `BcMath\Number` value object (doctrine#6686) PHPStan 2.1.1 (doctrine#6690) PHPUnit 10.5.39 (doctrine#6692) PHPUnit 9.6.22 (doctrine#6691) Bump doctrine/.github from 6.0.0 to 7.1.0 (doctrine#6649) Bump doctrine/.github from 5.3.0 to 6.0.0 (doctrine#6642)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 6, 2025
* 4.3.x: Enable platformOptions to be considered for ColumnDiff (PostgreSQL jsonb support) (doctrine#6693) Ignore new PHPStan errors Cleanup obsolete PHPStan ignore rules (doctrine#6697) Add a `NumberType` that maps to the `BcMath\Number` value object (doctrine#6686) PHPStan 2.1.1 (doctrine#6690) PHPUnit 10.5.39 (doctrine#6692) PHPUnit 9.6.22 (doctrine#6691) Bump doctrine/.github from 6.0.0 to 7.1.0 (doctrine#6649) Bump doctrine/.github from 5.3.0 to 6.0.0 (doctrine#6642)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changing
platformOptionscan also result in schema changes. In my concrete example it was thejsonboption for theJsonType. I updated first only PostgreSQLPlatform to get feedback if there are any pitfalls in adding theseplatformOptionsfor consideration of schema changes, wdyt?