Remove handling unuique constraint column names as associative array#6549
Merged
derrabus merged 1 commit intodoctrine:4.3.xfrom Oct 14, 2024
Conversation
Member
|
Looking at the constructor of |
253d2d6 to
300c0aa
Compare
Member
Author
|
@derrabus you're right. I was under the impression that this method would convert the associative array to the numeric one and pass down the line but it passes the original value. So yeah, dead code. |
derrabus
approved these changes
Oct 14, 2024
Member
|
Nice catch! |
derrabus
added a commit
that referenced
this pull request
Oct 21, 2024
* 4.3.x: Create stubs instead of mocks (#6564) [Bug] Query Cache mangled if saved by-reference (#6552) test: remove ->expects(self::any()) Fix typo in PostgreSql documentation reference fix Acknowledge the existence of 3.10 (#6553) Simplify tracking implicitly created indexes Remove handling unuique constraint column names as associative array (#6549) test: cover nested transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dual format serves no purpose and creates ambiguity. It is supported for unique constraints but not for any other schema objects.