Skip to content

Add SmallFloat type#6471

Merged
derrabus merged 9 commits intodoctrine:4.1.xfrom
berkut1:add-float4
Jul 22, 2024
Merged

Add SmallFloat type#6471
derrabus merged 9 commits intodoctrine:4.1.xfrom
berkut1:add-float4

Conversation

@berkut1
Copy link
Copy Markdown
Contributor

@berkut1 berkut1 commented Jul 16, 2024

Q A
Type feature

Summary

Recreated PR #6467 for branch 4.1.

This PR adds support for the REAL type for all DBMS, thereby resolving issues with partial support and potential bugs related to the REAL type in SQL schemas during migration creation. I've tried to explain this issue in detail through the INET type here #6466.

Checked DBMS:

  • PostgreSQL (represents REAL as float4 or real)
  • MySQL/MariaDB (Feature: Add Real/Float4 type #6467 (comment))
  • MSSQL (represents REAL as real)
  • Oracle (represents REAL as float(63)) doc
  • IBM DB2 (represents REAL as real)
  • SQLite (represents REAL as real)

@berkut1
Copy link
Copy Markdown
Contributor Author

berkut1 commented Jul 16, 2024

I don't understand why it says that the test doesn't cover case 'float' for Oracle when it should.

derrabus
derrabus reviewed Jul 16, 2024
View reviewed changes
Comment thread tests/Types/RealFloatTest.php Outdated
Comment thread tests/Functional/Schema/OracleSchemaManagerTest.php Outdated
@derrabus
Copy link
Copy Markdown
Member

derrabus commented Jul 16, 2024

I don't understand why it says that the test doesn't cover case 'float' for Oracle when it should.

CodeCov produces false positives at the moment when the upload of the coverage report fails.

@berkut1
Copy link
Copy Markdown
Contributor Author

berkut1 commented Jul 18, 2024

I guess need to re-run Github actions.

mvorisek
mvorisek reviewed Jul 19, 2024
View reviewed changes
Comment thread src/Types/RealFloatType.php Outdated
@berkut1 berkut1 changed the title feat: Add Real/Float4 type feat: Add Real/SmallFloat type Jul 20, 2024
@derrabus derrabus changed the title feat: Add Real/SmallFloat type Add Real/SmallFloat type Jul 21, 2024
derrabus
derrabus requested changes Jul 21, 2024
View reviewed changes
Comment thread docs/en/reference/types.rst Outdated
Comment thread tests/Types/SmallFloatTest.php Outdated
Comment thread tests/Types/SmallFloatTest.php Outdated
@derrabus derrabus added this to the 4.1.0 milestone Jul 22, 2024
@derrabus derrabus changed the title Add Real/SmallFloat type Add SmallFloat type Jul 22, 2024
@derrabus derrabus merged commit 6ebcb77 into doctrine:4.1.x Jul 22, 2024
@derrabus
Copy link
Copy Markdown
Member

derrabus commented Jul 22, 2024

Thank you!

derrabus added a commit to derrabus/dbal that referenced this pull request Jul 23, 2024
@derrabus
Merge branch '4.1.x' into 5.0.x
162caab 
* 4.1.x:
  Properly handle MySQL error code 4031 from PHP 8.4 (doctrine#6363)
  Add SmallFloat type (doctrine#6471)
  CI: Add MySQL 9, reduce test matrix (doctrine#6462)
  Fix update/delete aliases in documentation (doctrine#6470)
  Complete sentence
  Docs: update custom platform example to use middlewares (doctrine#6460)
  ci: nightly - php-8.1 only + workflow_dispatch
  ci: nightly - php-8.1 min version (doctrine#6457)
  mariadb: add nightly workflow to facilitate mariadb "nightlies" (doctrine#6435)
@janedbal janedbal mentioned this pull request Apr 24, 2025
Merged
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@derrabus derrabus derrabus approved these changes

+1 more reviewer

@mvorisek mvorisek mvorisek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

New Feature Type Mapping Types

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@berkut1 @derrabus @mvorisek