Keep NVARCHAR(MAX) length as -1#6251
Merged
derrabus merged 1 commit intodoctrine:3.7.xfrom Jan 20, 2024
Merged
Conversation
62b57ae to
f016911
Compare
f016911 to
8fbea8d
Compare
8fbea8d to
9a256b9
Compare
derrabus
approved these changes
Jan 20, 2024
Member
|
Thank you. |
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 20, 2024
* 3.7.x: Keep NVARCHAR(MAX) length as -1 (doctrine#6251)
derrabus
added a commit
to derrabus/dbal
that referenced
this pull request
Jan 20, 2024
* 3.8.x: Keep NVARCHAR(MAX) length as -1 (doctrine#6251)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As described in the mentioned issue,
-0.5from-1 / 2will raise type error when trying tosetLengthdbal/src/Schema/Column.php
Line 78 in 8bc0d9a
This PR check if length is
-1and keep it as is before perform division.