Skip to content

Remove platform-unaware schema comparison API#4771

Merged
morozov merged 1 commit intodoctrine:4.0.xfrom
morozov:remove-platform-unaware-comparison
Sep 8, 2021
Merged

Remove platform-unaware schema comparison API#4771
morozov merged 1 commit intodoctrine:4.0.xfrom
morozov:remove-platform-unaware-comparison

Conversation

@morozov
Copy link
Copy Markdown
Member

@morozov morozov commented Aug 29, 2021

Q A
Type improvement
BC Break yes

See #4746.

@morozov morozov force-pushed the remove-platform-unaware-comparison branch from ebab650 to 309da3f Compare August 29, 2021 23:10
@morozov morozov marked this pull request as ready for review August 29, 2021 23:18
@morozov morozov requested review from derrabus and greg0ire August 29, 2021 23:18
@morozov morozov merged commit cd62cf4 into doctrine:4.0.x Sep 8, 2021
@morozov morozov deleted the remove-platform-unaware-comparison branch September 8, 2021 21:26
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2022
This code was relevant before the improvement in
doctrine#4746 was implemented. The new
comparator API is enforced in
doctrine#4771.

Now, the comparator will not produce a false-positive diff which is
enforced by the new test.
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2022
This code was relevant before the improvement in
doctrine#4746 was implemented. The new
comparator API is enforced in
doctrine#4771.

Now, the comparator will not produce a false-positive diff which is
enforced by the new test.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants