Conversation
4c5b4a0 to
7f23986
Compare
|
In its current state it would also fit well to other projects than dbal. Could this be used as a generic guideline on the website or will this diverge more from the other projects (except platforms)? |
|
My goal is to have the DBAL documentation first. Once it's done content-wise, we can see how it could be restructured into the generic and DBAL-specific sections. I'm open to suggestions and contributions. |
0e93fe3 to
03d29b6
Compare
|
I could use some help with the examples (if needed) and feedback on whether some ideas need to be clarified. |
docs/en/reference/testing.rst
Outdated
| with other units. In this case, the other units could be mocked. | ||
|
|
||
| Unit tests are mostly welcomed for testing the logic that the DBAL itself defines (e.g. logging). They also could be | ||
| used as a secondary tier of testing for the logic that requires integration testing. |
There was a problem hiding this comment.
That last sentence could be clarified with an example.
There was a problem hiding this comment.
I moved this under the "Using Unit and Integration Tests Together" section. The wording is to be revisited.
57b5b16 to
491ec67
Compare
|
I haven't been finding much passion lately to finish this document, so in order to not let it rot, let's give it another round of proofreading and try to not increase the scope. The primary idea I want to convey is the need to write integration tests across all supported platforms as I have been asking contributors dozens and dozens of times. Everybody can contribute to this guide afterward and add the other important bits. |
491ec67 to
b2b1dbf
Compare
b2b1dbf to
394e119
Compare
ee8692c to
5f8397a
Compare
SenseException
left a comment
There was a problem hiding this comment.
I haven't been finding much passion lately to finish this document, so in order to not let it rot, let's give it another round of proofreading and try to not increase the scope.
Okay 👍 . Just have a small change, otherwise this is ready for a merge IMO.
5f8397a to
013a511
Compare
013a511 to
b085da7
Compare
|
@SenseException how do we get this deployed to the website? |
Release [2.12.1](https://github.com/doctrine/dbal/milestone/84) 2.12.1 ====== - Total issues resolved: **2** - Total pull requests resolved: **11** - Total contributors: **7** Documentation,Prepared Statements --------------------------------- - [4424: Mark SQLParserUtils internal](doctrine#4424) thanks to @morozov Packaging --------- - [4416: Update .gitattributes](doctrine#4416) thanks to @bytestream Bug,Cache --------- - [4414: ResultCacheStatement::fetchAllAssociative does not store results in cache](doctrine#4414) thanks to @morozov and @dFayet Deprecation,Prepared Statements ------------------------------- - [4411: Deprecate inappropriate usage of prepared statement parameters](doctrine#4411) thanks to @morozov - [4407: Deprecate colon prefix for prepared statement parameters](doctrine#4407) thanks to @morozov Static Analysis --------------- - [4403: Remove redundant phpstan param from DriverManager::getConnection()](doctrine#4403) thanks to @simPod Bug,Locking,Transactions ------------------------ - [4400: LockMode::NONE should not set WITH (NOLOCK)](doctrine#4400) thanks to @BenMorel Code Style,PHP -------------- - [4398: Update PHP&doctrine#95;CodeSniffer to 3.5.8](doctrine#4398) thanks to @morozov PDO,PHP,Test Suite ------------------ - [4396: Fix php8 mysql mariadb](doctrine#4396) thanks to @greg0ire Documentation ------------- - [4390: Fix headline in the upgrade docs](doctrine#4390) thanks to @jdreesen Documentation,Testing --------------------- - [4356: Testing Guidelines](doctrine#4356) thanks to @morozov # gpg: Signature made Sat Nov 14 21:50:01 2020 # gpg: using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132 # gpg: Can't check signature: No public key # Conflicts: # README.md
This is a placeholder and a temporary reference for the testing requirements and guidelines.
TODO: