Fixed the QueryBuilder::setMaxResults() signature to accept NULL#3840
Merged
morozov merged 1 commit intodoctrine:masterfrom Jan 22, 2020
Merged
Fixed the QueryBuilder::setMaxResults() signature to accept NULL#3840morozov merged 1 commit intodoctrine:masterfrom
morozov merged 1 commit intodoctrine:masterfrom
Conversation
The original signature was improperly documented which later became enforced.
Member
Author
|
Once accepted, the relevant bits need to be backported to |
greg0ire
approved these changes
Jan 22, 2020
morozov
added a commit
that referenced
this pull request
Jan 22, 2020
Fixed the QueryBuilder::setMaxResults() signature to accept NULL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original signature was improperly documented using an annotation which later was converted to an argument type declaration.