Removed Connection::project()#3823
Merged
morozov merged 1 commit intodoctrine:masterfrom Jan 16, 2020
Merged
Conversation
The methods has more limitations and caveats than provides real use: 1. It fetches all data in memory which is often inefficient (see doctrine#2718). 2. It fetches rows in memory one by one instead of using `fetchAll()`. 4. It doesn't allow to specify the statement fetch mode since it's instantiated internally. 5. It can be easily replaced with: ```php foreach ($conn->executeQuery($query, $params, $types) as $value) { yield $function($value); } ```
greg0ire
approved these changes
Jan 16, 2020
This was referenced May 23, 2020
beberlei
added a commit
to beberlei/dbal
that referenced
this pull request
Mar 7, 2021
beberlei
added a commit
to beberlei/dbal
that referenced
this pull request
Mar 7, 2021
beberlei
added a commit
to beberlei/dbal
that referenced
this pull request
Mar 11, 2021
beberlei
added a commit
to beberlei/dbal
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As originally discussed in #3703 (comment), the method has more limitations and caveats than provides real use:
fetchAll().