Skip to content

Enable phpstan in DBAL tests#3582

Merged
morozov merged 3 commits intodoctrine:developfrom
jwage:phpstan-tests
Jun 5, 2019
Merged

Enable phpstan in DBAL tests#3582
morozov merged 3 commits intodoctrine:developfrom
jwage:phpstan-tests

Conversation

@jwage
Copy link
Copy Markdown
Member

@jwage jwage commented May 31, 2019

Q A
Type improvement
BC Break no

Summary

Enable phpstan in DBAL tests.

@jwage jwage added this to the 3.0.0 milestone May 31, 2019
morozov
morozov reviewed Jun 1, 2019
View reviewed changes
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jun 1, 2019

Failures are only in CS:

FILE: tests/Doctrine/Tests/DBAL/Types/JsonTest.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 15 | ERROR | [x] Type RuntimeException is not used in this file.
    |       |     (SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse)
 18 | ERROR | [x] Type json_encode is not used in this file.
    |       |     (SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: tests/Doctrine/Tests/DBAL/Functional/TemporaryTableTest.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 15 | ERROR | Class TemporaryTableTest contains write-only property
    |       | $tempTableCreated.
    |       | (SlevomatCodingStandard.Classes.UnusedPrivateElements.WriteOnlyProperty)
--------------------------------------------------------------------------------

This was referenced Jun 2, 2019
Closed
Closed
@morozov
Copy link
Copy Markdown
Member

morozov commented Jun 5, 2019

I only noticed now that the PR targeted against develop. Since it's not supposed to contain breaking changes, should we retarget it against master?

@jwage
Copy link
Copy Markdown
Member Author

jwage commented Jun 5, 2019

I can try and see how hard it will be to rebase against master.

@jwage
Copy link
Copy Markdown
Member Author

jwage commented Jun 5, 2019

I don't think doing this against master will work because the changes made to the tests depend on all the type and api work that we did in develop.

@morozov
Copy link
Copy Markdown
Member

morozov commented Jun 5, 2019

At least we tried. Maybe it could be done later. It still would make sense to get it in master because this is where we get most of the code changes before 3.0 is released.

@jwage jwage requested a review from morozov June 5, 2019 20:24
@morozov morozov merged commit 3887c5b into doctrine:develop Jun 5, 2019
@jwage jwage deleted the phpstan-tests branch June 5, 2019 22:55
@morozov morozov self-assigned this Jun 7, 2019
morozov added a commit that referenced this pull request Jun 13, 2019
@morozov
Merge pull request #3582 from jwage/phpstan-tests
207a33d 
Enable phpstan in DBAL tests
@morozov morozov mentioned this pull request Jun 15, 2019
Merged
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3582 from jwage/phpstan-tests
c2966dd 
Enable phpstan in DBAL tests
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3582 from jwage/phpstan-tests
5534ada 
Enable phpstan in DBAL tests
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3582 from jwage/phpstan-tests
db8c214 
Enable phpstan in DBAL tests
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3582 from jwage/phpstan-tests
408d815 
Enable phpstan in DBAL tests
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3582 from jwage/phpstan-tests
c02c3ea 
Enable phpstan in DBAL tests
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3582 from jwage/phpstan-tests
3bb300c 
Enable phpstan in DBAL tests
morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019
@morozov
Merge pull request doctrine#3582 from jwage/phpstan-tests
42c9ead 
Enable phpstan in DBAL tests
morozov added a commit that referenced this pull request Nov 2, 2019
@morozov
Merge pull request #3582 from jwage/phpstan-tests
e4aa401 
Enable phpstan in DBAL tests
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morozov morozov morozov approved these changes

+1 more reviewer

@Ocramius Ocramius Ocramius left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@morozov morozov

Labels

Improvement Strict Typing Test Suite

Projects

None yet

Milestone

4.0.0-beta1

Development

Successfully merging this pull request may close these issues.

4 participants

@jwage @Ocramius @morozov @Majkl578