Consider column lengths when comparing indices#3415
Merged
morozov merged 1 commit intodoctrine:masterfrom Dec 27, 2018
Merged
Conversation
Member
Author
|
Not sure how this is supposed to work when the target platform doesn't support index lengths but they are specified in the metadata. Something should remove lengths from the target definitions in order to avoid the diff which is impossible to eliminate. |
Ocramius
suggested changes
Dec 19, 2018
Contributor
|
Thank you @morozov. 👍 |
|
We started seeing the following error after updating from
The schema tool did try to drop and create the index, but was not able to make the change. We were able to solve it by manually removing the index length, after which the schema tool did not detect a change for the index anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing indices, compare column lengths as well. Fixes #3414.