Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()#3369
Merged
Ocramius merged 1 commit intodoctrine:developfrom Dec 1, 2018
Merged
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()#3369Ocramius merged 1 commit intodoctrine:developfrom
Ocramius merged 1 commit intodoctrine:developfrom
Conversation
Ocramius
suggested changes
Dec 1, 2018
Member
Author
|
@Ocramius, retargeted. |
Ocramius
approved these changes
Dec 1, 2018
Member
|
🚢 |
morozov
pushed a commit
that referenced
this pull request
Dec 6, 2018
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()
morozov
pushed a commit
that referenced
this pull request
Jan 20, 2019
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()
morozov
pushed a commit
to morozov/dbal
that referenced
this pull request
Feb 6, 2019
Handle binding errors in OCI8Statement::execute() and MySQLiStatement::execute()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MysqliStatement: regardless of whether the underlying statement has bound variables, try binding the parameters passed to the DBAL statement to get them validated by the driver.OCI8Statement: do not ignore the return value ofoci_bind_by_name().