Remove Doctrine\DBAL\Types\Type::__toString()#3257
Merged
morozov merged 1 commit intodoctrine:developfrom Aug 18, 2018
Merged
Conversation
morozov
approved these changes
Aug 18, 2018
Member
morozov
left a comment
There was a problem hiding this comment.
Not sure if relying on FQCN is any better than relying on a made-up name but __toString() shouldn't bepart of the API in any event.
morozov
added a commit
that referenced
this pull request
Sep 29, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Oct 7, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Oct 7, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Nov 14, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Nov 14, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Nov 25, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Dec 6, 2018
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
that referenced
this pull request
Jan 20, 2019
Remove Doctrine\DBAL\Types\Type::__toString()
morozov
added a commit
to morozov/dbal
that referenced
this pull request
Feb 6, 2019
…tring Remove Doctrine\DBAL\Types\Type::__toString()
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relying on __toString() internally was already removed in #2835, it's not obsolete and untested API.
1st step towards #2841 (Refactoring type system).