Fixed and suppressed issues found by PHPStan on develop by morozov · Pull Request #3238 · doctrine/dbal

morozov · 2018-08-03T06:30:25Z

Q	A
Type	improvement
BC Break	no
Fixed issues	none

As of #3025, the develop builds fail due to the issues which didn't exist and weren't fixed in master.

#3236 and #3237 have been separately filed as release blockers for 3.0 since fixing them requires a deeper understanding of the underlying issues than I currently have.

morozov · 2018-08-03T06:34:06Z

phpstan.neon.dist


        # http://php.net/manual/en/pdo.sqlitecreatefunction.php
-        - '~^Call to an undefined method Doctrine\\DBAL\\Driver\\PDOConnection::sqliteCreateFunction\(\)\.\z~'
+        - '~^Call to an undefined method PDO::sqliteCreateFunction\(\)\.\z~'


@Majkl578 while I understand the PHPStan's inability to use stubbed PDO::SQLSRV_* constants, what's the reason we should white-list this method? As long as pdo_sqlite is loaded on Travis, shouldn't PHPStan be able to see it via the extension reflection?

As long as pdo_sqlite is loaded

Exactly, as long as it is loaded. And pdo_sqlite is not direct dependency in composer.json, so you may not have it enabled locally. And polyfills can't add methods/constants to existing classes.
Maybe we should have two phpstan configs with specific ignores for Travis.

This is als why I disabled reportUnmatchedIgnoredErrors, since different people/environments have different extensions.

Gotcha. I thought this issue was reproducible despite whether pdo_sqlite was loaded or not.

The necessity to use reportUnmatchedIgnoredErrors() across the board and the fact that PHP extensions can add members to existing classes (which is impossible in PHP) looks like a ground for PHPStan to implement this "extensibility" feature for stubs as well. I.e. it should initialize from the extension reflection and then merge the stubbed symbols in. Does it sound like a reasonable feature request?

Ocramius · 2018-08-03T12:19:42Z

👍

Fixed and suppressed issues found by PHPStan on develop

Fixed and suppressed issues found by PHPStan on develop

9a197ee

morozov commented Aug 3, 2018

View reviewed changes

morozov requested a review from Majkl578 August 3, 2018 06:35

morozov self-assigned this Aug 3, 2018

morozov added the CI label Aug 3, 2018

morozov added this to the 3.0.0 milestone Aug 3, 2018

morozov added the Documentation label Aug 3, 2018

Majkl578 approved these changes Aug 3, 2018

View reviewed changes

Ocramius merged commit e646ba5 into doctrine:develop Aug 3, 2018

morozov deleted the phpstan-develop branch August 3, 2018 17:13

morozov pushed a commit that referenced this pull request Aug 7, 2018

Merge pull request #3238 from morozov/phpstan-develop

9f9d347

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Sep 29, 2018

Merge pull request #3238 from morozov/phpstan-develop

6a33574

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Oct 7, 2018

Merge pull request #3238 from morozov/phpstan-develop

84042cb

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Oct 7, 2018

Merge pull request #3238 from morozov/phpstan-develop

c24b789

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Nov 14, 2018

Merge pull request #3238 from morozov/phpstan-develop

560ffce

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Nov 14, 2018

Merge pull request #3238 from morozov/phpstan-develop

8e3110a

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Nov 25, 2018

Merge pull request #3238 from morozov/phpstan-develop

fbc7fb6

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Dec 6, 2018

Merge pull request #3238 from morozov/phpstan-develop

b7e5b96

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Jan 20, 2019

Merge pull request #3238 from morozov/phpstan-develop

0a2ec59

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit to morozov/dbal that referenced this pull request Feb 6, 2019

Merge pull request doctrine#3238 from morozov/phpstan-develop

750277b

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit to morozov/dbal that referenced this pull request Feb 6, 2019

Merge pull request doctrine#3238 from morozov/phpstan-develop

7430da8

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Feb 7, 2019

Merge pull request #3238 from morozov/phpstan-develop

ac8f418

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Feb 20, 2019

Merge pull request #3238 from morozov/phpstan-develop

429c9c1

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Feb 22, 2019

Merge pull request #3238 from morozov/phpstan-develop

32490ad

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Mar 15, 2019

Merge pull request #3238 from morozov/phpstan-develop

2c9a670

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Mar 15, 2019

Merge pull request #3238 from morozov/phpstan-develop

38c174c

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Mar 18, 2019

Merge pull request #3238 from morozov/phpstan-develop

d866cf4

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Apr 16, 2019

Merge pull request #3238 from morozov/phpstan-develop

d1214a2

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request May 6, 2019

Merge pull request #3238 from morozov/phpstan-develop

06c72fd

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request May 23, 2019

Merge pull request #3238 from morozov/phpstan-develop

35eec30

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit to morozov/dbal that referenced this pull request May 31, 2019

Merge pull request doctrine#3238 from morozov/phpstan-develop

1359d1f

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Jun 13, 2019

Merge pull request #3238 from morozov/phpstan-develop

b1515c8

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Jun 27, 2019

Merge pull request #3238 from morozov/phpstan-develop

ef9d8c4

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit to morozov/dbal that referenced this pull request Aug 26, 2019

Merge pull request doctrine#3238 from morozov/phpstan-develop

7ea0f62

Fixed and suppressed issues found by PHPStan on develop

morozov pushed a commit that referenced this pull request Nov 2, 2019

Merge pull request #3238 from morozov/phpstan-develop

44133f0

Fixed and suppressed issues found by PHPStan on develop

This was referenced Dec 30, 2019

Research the possibility to backport PDO-related changes from master to 2.10 #3798

Closed

Backport PDO-related changes from master to 3.0.x #3803

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022

morozov removed this from the 4.0.0 milestone Aug 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed and suppressed issues found by PHPStan on develop#3238

Fixed and suppressed issues found by PHPStan on develop#3238
Ocramius merged 1 commit intodoctrine:developfrom
morozov:phpstan-develop

morozov commented Aug 3, 2018 •

edited

Loading

Uh oh!

morozov Aug 3, 2018

Uh oh!

Majkl578 Aug 3, 2018

Uh oh!

Majkl578 Aug 3, 2018

Uh oh!

morozov Aug 3, 2018 •

edited

Loading

Uh oh!

Ocramius commented Aug 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

morozov commented Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

morozov Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

Majkl578 Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

Majkl578 Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

morozov Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ocramius commented Aug 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

morozov commented Aug 3, 2018 •

edited

Loading

morozov Aug 3, 2018 •

edited

Loading